fix: blocks UI elements on right side #30886

samarsrivastav · 2024-11-10T07:07:51Z

fix(dashboard): load charts correctly

Fixes #30879

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

shown in the issue #30879

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

samarsrivastav · 2024-11-11T15:36:46Z

hey @rusackas !! can i connect with you on slack or something, i have some doubts regarding the setup of the codebase

rusackas · 2024-11-12T03:04:04Z

By all means, slack away... or start a GitHub Discussion and tag me there if you want more eyes on it.

superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx

rusackas · 2024-11-12T19:35:23Z

superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx

@@ -32,6 +32,7 @@ import ResizableContainer from 'src/dashboard/components/resizable/ResizableCont
 import getChartAndLabelComponentIdFromPath from 'src/dashboard/util/getChartAndLabelComponentIdFromPath';
 import useFilterFocusHighlightStyles from 'src/dashboard/util/useFilterFocusHighlightStyles';
 import { COLUMN_TYPE, ROW_TYPE } from 'src/dashboard/util/componentTypes';
+import { useTheme } from '@superset-ui/core';


Ahh, you can add this import to line 25, so you're not importing stuff from superset-ui/core twice (it's a listing error). Sorry, I should have been clearer. Also, sorry you even have to DO this stuff... but it's all stuff that sets things up better for the next person :)

rusackas · 2024-11-12T19:42:24Z

superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx

@@ -69,13 +70,14 @@ interface ChartHolderProps {
  setFullSizeChartId: (chartId: number | null) => void;
  isInView: boolean;
 }
-
+const theme=useTheme()


Looks like this (and the style const below it) might need to go within the function component... or there are other workarounds for that. Holler if you want any help here, I might be able to push commits to your fork/branch

samarsrivastav · 2024-11-14T13:45:48Z

hey @rusackas , can you check it now

sadpandajoe · 2024-11-14T18:21:24Z

@samarsrivastav looks like there are some failures with pre-commit hooks. Mind running them?

rusackas · 2024-11-15T16:43:44Z

Thank you @samarsrivastav! Looks good!

Co-authored-by: Evan Rusackas <evan@preset.io> (cherry picked from commit df47994)

* fix: Exception handling for SQL Lab views (apache#30897) * fix: don't show metadata for embedded dashboards (apache#30875) * feat: add logging durations for screenshot async service (apache#30884) * refactor(Avatar): Migrate Avatar to Ant Design 5 (apache#30740) * refactor(input): Migrate Input component to Ant Design 5 (apache#30730) * fix(empty dashboards): Allow downloading a screenshot of an empty dashboard (apache#30767) Co-authored-by: Geido <60598000+geido@users.noreply.github.com> * chore(ci): add tai and michael to helm owners (apache#30925) * fix(helm): use submodule on helm release action (apache#30924) * docs: add Free2Move to INTHEWILD.md (apache#30930) * fix: blocks UI elements on right side (apache#30886) Co-authored-by: Evan Rusackas <evan@preset.io> * chore(deps): Migrate from `crate[sqlalchemy]` to `sqlalchemy-cratedb` (apache#29243) * chore: update change log, UPDATING.md and bug-report.yml for 4.1 release (apache#30915) * chore(docs): Update list of supported databases to include CrateDB (apache#30946) * feat(trino,presto): add missing time grains (apache#30926) * fix(Dashboard): Exclude edit param in async screenshot (apache#30962) * fix(Card): Use correct class names for Ant Design 5 Card component (apache#30964) * chore(Accessibility): Fix accessibility for 'Show x entries' dropdown in tables (apache#30818) * build(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /superset-frontend/cypress-base (apache#30969) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(release validation): scripts now support RSA and EDDSA keys. (apache#30967) * build(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs (apache#30970) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: add performance information to tooltip (apache#30948) * fix(helm-chart): Fix broken PodDisruptionBudget due to introduction of extraLabels. (apache#30966) * chore(helm): bumping app version to 4.1.1 in helm chart (apache#30918) * chore: add unit tests for `is_mutating()` (apache#31021) * chore(🦾): bump python numexpr 2.10.0 -> 2.10.1 (apache#31006) Co-authored-by: GitHub Action <action@github.com> * chore(🦾): bump python cffi 1.16.0 -> 1.17.1 (apache#31002) Co-authored-by: GitHub Action <action@github.com> * chore(🦾): bump python flask-babel subpackage(s) (apache#31000) Co-authored-by: GitHub Action <action@github.com> * fix(Dashboard): Retain colors when color scheme not set (apache#30646) * fix(explore): verified props is not updated (apache#31008) * chore: publish wheels (apache#30981) * docs: Embedded sdk (apache#30972) * fix(imports): import query_context for imports with charts (apache#30887) * docs: Update doc about CSV upload (apache#30867) Co-authored-by: Evan Rusackas <evan@preset.io> * chore(🦾): bump python cattrs 23.2.3 -> 24.1.2 (apache#30998) Co-authored-by: GitHub Action <action@github.com> * fix(dataset): use sqlglot for DML check (apache#31024) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Joe Li <joe@preset.io> Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com> Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Paolo Terzi <PaoloTerzi@users.noreply.github.com> Co-authored-by: Sukuna <90980311+samarsrivastav@users.noreply.github.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Andreas Motl <andreas.motl@elmyra.de> Co-authored-by: Andreas Motl <andreas.motl@crate.io> Co-authored-by: Levis Mbote <111055098+LevisNgigi@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Christoph Keller <github@christophkeller.cc> Co-authored-by: lodu <48859312+lodu@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: David Hotham <david.hotham@microsoft.com> Co-authored-by: Giampaolo Capelli <giampaolo.capelli@gmail.com> Co-authored-by: Linden <zairrow@gmail.com> Co-authored-by: Seiya <20365512+seiyab@users.noreply.github.com> Co-authored-by: Asher Manangan <amanangan@powercosts.com>

Co-authored-by: Evan Rusackas <evan@preset.io> (cherry picked from commit df47994)

fix:blocks UI elements on right side

4b406cb

pull-request-size bot added the size/XS label Nov 10, 2024

dosubot bot added the dashboard:design Related to the Dashboard UI/UX label Nov 10, 2024

rusackas reviewed Nov 11, 2024

View reviewed changes

superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx Outdated Show resolved Hide resolved

Update padding

a98a427

Co-authored-by: Evan Rusackas <evan@preset.io>

rusackas approved these changes Nov 12, 2024

View reviewed changes

rusackas changed the title ~~fix:blocks UI elements on right side~~ fix: blocks UI elements on right side Nov 12, 2024

rusackas reviewed Nov 12, 2024

View reviewed changes

superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx Outdated Show resolved Hide resolved

Fetching theme at ChartHolder.tsx

cf95b64

rusackas reviewed Nov 12, 2024

View reviewed changes

Update ChartHolder.tsx

46da828

pull-request-size bot added size/S and removed size/XS labels Nov 14, 2024

lint

7c18c7f

rusackas merged commit df47994 into apache:master Nov 15, 2024
34 checks passed

sadpandajoe pushed a commit that referenced this pull request Nov 15, 2024

fix: blocks UI elements on right side (#30886)

1410e52

Co-authored-by: Evan Rusackas <evan@preset.io> (cherry picked from commit df47994)

michael-s-molina pushed a commit that referenced this pull request Nov 19, 2024

fix: blocks UI elements on right side (#30886)

dd80526

Co-authored-by: Evan Rusackas <evan@preset.io> (cherry picked from commit df47994)

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 4.1.1 labels Nov 27, 2024

betodealmeida pushed a commit that referenced this pull request Jan 14, 2025

fix: blocks UI elements on right side (#30886)

27648c1

Co-authored-by: Evan Rusackas <evan@preset.io> (cherry picked from commit df47994)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: blocks UI elements on right side #30886

fix: blocks UI elements on right side #30886

samarsrivastav commented Nov 10, 2024

samarsrivastav commented Nov 11, 2024 •

edited

Loading

rusackas commented Nov 12, 2024

rusackas Nov 12, 2024

rusackas Nov 12, 2024

samarsrivastav commented Nov 14, 2024

sadpandajoe commented Nov 14, 2024

rusackas commented Nov 15, 2024

fix: blocks UI elements on right side #30886

fix: blocks UI elements on right side #30886

Conversation

samarsrivastav commented Nov 10, 2024

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

samarsrivastav commented Nov 11, 2024 • edited Loading

rusackas commented Nov 12, 2024

rusackas Nov 12, 2024

Choose a reason for hiding this comment

rusackas Nov 12, 2024

Choose a reason for hiding this comment

samarsrivastav commented Nov 14, 2024

sadpandajoe commented Nov 14, 2024

rusackas commented Nov 15, 2024

samarsrivastav commented Nov 11, 2024 •

edited

Loading