Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Removes the Filter Box code #26328

Merged
merged 10 commits into from
Jan 19, 2024

Addresses comments

894baf5
Select commit
Loading
Failed to load commit list.
Merged

refactor: Removes the Filter Box code #26328

Addresses comments
894baf5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 19, 2024 in 1s

51.28% of diff hit (target 69.28%)

View this Pull Request on Codecov

51.28% of diff hit (target 69.28%)

Annotations

Check warning on line 584 in superset-frontend/src/dashboard/actions/dashboardState.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset-frontend/src/dashboard/actions/dashboardState.js#L584 

Added line #L584 was not covered by tests

Check warning on line 27 in superset-frontend/src/dashboard/util/logging/childChartsDidLoad.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset-frontend/src/dashboard/util/logging/childChartsDidLoad.js#L27 

Added line #L27 was not covered by tests

Check warning on line 88 in superset/commands/chart/importers/v1/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/commands/chart/importers/v1/__init__.py#L88 

Added line #L88 was not covered by tests

Check warning on line 163 in superset/commands/dashboard/importers/v1/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/commands/dashboard/importers/v1/__init__.py#L163 

Added line #L163 was not covered by tests

Check warning on line 156 in superset/commands/importers/v1/assets.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/commands/importers/v1/assets.py#L156 

Added line #L156 was not covered by tests

Check warning on line 50 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L50 

Added line #L50 was not covered by tests

Check warning on line 52 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L52 

Added line #L52 was not covered by tests

Check warning on line 65 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L64-L65 

Added lines #L64 - L65 were not covered by tests

Check warning on line 68 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L67-L68 

Added lines #L67 - L68 were not covered by tests

Check warning on line 70 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L70 

Added line #L70 was not covered by tests

Check warning on line 85 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L84-L85 

Added lines #L84 - L85 were not covered by tests

Check warning on line 94 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L93-L94 

Added lines #L93 - L94 were not covered by tests

Check warning on line 97 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L96-L97 

Added lines #L96 - L97 were not covered by tests

Check warning on line 102 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L101-L102 

Added lines #L101 - L102 were not covered by tests

Check warning on line 111 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L110-L111 

Added lines #L110 - L111 were not covered by tests

Check warning on line 114 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L113-L114 

Added lines #L113 - L114 were not covered by tests

Check warning on line 119 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L118-L119 

Added lines #L118 - L119 were not covered by tests

Check warning on line 128 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L127-L128 

Added lines #L127 - L128 were not covered by tests

Check warning on line 131 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L130-L131 

Added lines #L130 - L131 were not covered by tests

Check warning on line 138 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L136-L138 

Added lines #L136 - L138 were not covered by tests

Check warning on line 169 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L167-L169 

Added lines #L167 - L169 were not covered by tests

Check warning on line 172 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L171-L172 

Added lines #L171 - L172 were not covered by tests

Check warning on line 175 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L175 

Added line #L175 was not covered by tests

Check warning on line 178 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L177-L178 

Added lines #L177 - L178 were not covered by tests

Check warning on line 186 in superset/migrations/shared/native_filters.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

superset/migrations/shared/native_filters.py#L185-L186 

Added lines #L185 - L186 were not covered by tests
View more details on Codecov