Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Removes the Filter Box code #26328

Merged
merged 10 commits into from
Jan 19, 2024

Addresses comments

894baf5
Select commit
Loading
Failed to load commit list.
Merged

refactor: Removes the Filter Box code #26328

Addresses comments
894baf5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 19, 2024 in 0s

69.57% (+0.28%) compared to 8f8c435

View this Pull Request on Codecov

69.57% (+0.28%) compared to 8f8c435

Details

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (8f8c435) 69.28% compared to head (894baf5) 69.57%.
Report is 1 commits behind head on master.

Files Patch % Lines
superset/migrations/shared/native_filters.py 37.50% 70 Missing ⚠️
...t-frontend/src/dashboard/actions/dashboardState.js 0.00% 1 Missing ⚠️
...ard/components/filterscope/FilterScopeSelector.jsx 0.00% 0 Missing and 1 partial ⚠️
...d/src/dashboard/util/logging/childChartsDidLoad.js 0.00% 1 Missing ⚠️
superset/commands/chart/importers/v1/__init__.py 50.00% 1 Missing ⚠️
...perset/commands/dashboard/importers/v1/__init__.py 90.90% 1 Missing ⚠️
superset/commands/importers/v1/assets.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #26328      +/-   ##
==========================================
+ Coverage   69.28%   69.57%   +0.28%     
==========================================
  Files        1909     1893      -16     
  Lines       74875    74220     -655     
  Branches     8398     8263     -135     
==========================================
- Hits        51876    51635     -241     
+ Misses      20856    20504     -352     
+ Partials     2143     2081      -62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov