Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove code deprecated in 2.0 #24126

Closed
wants to merge 9 commits into from

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented May 18, 2023

SUMMARY

  • remove code deprecated in 2.0 or earlier
  • #22022

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #24126 (9df7458) into master (6dba6e3) will increase coverage by 10.14%.
The diff coverage is n/a.

❗ Current head 9df7458 differs from pull request most recent head 2b3d969. Consider uploading reports for the commit 2b3d969 to get more accurate results

@@             Coverage Diff             @@
##           master   #24126       +/-   ##
===========================================
+ Coverage   58.16%   68.30%   +10.14%     
===========================================
  Files        1901     1957       +56     
  Lines       74000    75485     +1485     
  Branches     8116     8223      +107     
===========================================
+ Hits        43043    51561     +8518     
+ Misses      28846    21817     -7029     
+ Partials     2111     2107        -4     
Flag Coverage Δ
hive 53.47% <ø> (-0.46%) ⬇️
mysql 78.94% <ø> (?)
postgres 79.01% <ø> (?)
presto 53.40% <ø> (-0.44%) ⬇️
python 82.85% <ø> (+21.96%) ⬆️
sqlite 77.55% <ø> (?)
unit 53.53% <ø> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 76.09% <ø> (+43.34%) ⬆️

... and 508 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lilykuang lilykuang force-pushed the remove_deprecated_2.0 branch from a92bed7 to 0a7773d Compare May 19, 2023 03:31
@lilykuang lilykuang requested a review from hughhhh May 19, 2023 04:02
@lilykuang lilykuang force-pushed the remove_deprecated_2.0 branch from 79dd8bb to a345fb1 Compare May 19, 2023 23:28
@lilykuang lilykuang force-pushed the remove_deprecated_2.0 branch 6 times, most recently from cb7908d to c31c9c5 Compare May 22, 2023 21:09
@lilykuang lilykuang force-pushed the remove_deprecated_2.0 branch 2 times, most recently from d180b7f to 29a475f Compare May 24, 2023 22:05
@lilykuang lilykuang force-pushed the remove_deprecated_2.0 branch from 29a475f to 9638f31 Compare May 25, 2023 13:22
@rusackas rusackas added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 8, 2023
@rusackas
Copy link
Member

rusackas commented Jun 8, 2023

Is any of this considered a breaking change? If so, we'd need the risk:breaking-change label, and an entry in UPDATING.md

@lilykuang lilykuang closed this Jun 20, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants