fix: deprecate approve and request_access endpoint

[dpgaspar]

SUMMARY

Changes both /superset/approve and /superset/request_access to HTTP POST.
Since these endpoints change the state of the system GET is not correct

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #22022 (a927654) into master (7d1df3b) will decrease coverage by 11.49%.
The diff coverage is 50.00%.

❗ Current head a927654 differs from pull request most recent head 193d90f. Consider uploading reports for the commit 193d90f to get more accurate results

@@             Coverage Diff             @@
##           master   #22022       +/-   ##
===========================================
- Coverage   66.97%   55.48%   -11.50%     
===========================================
  Files        1815     1815               
  Lines       69540    69542        +2     
  Branches     7483     7483               
===========================================
- Hits        46575    38585     -7990     
- Misses      21034    29026     +7992     
  Partials     1931     1931               

Flag	Coverage Δ
hive	?
mysql	?
postgres	?
presto	52.74% <50.00%> (-0.01%)	⬇️
python	57.66% <50.00%> (-23.85%)	⬇️
unit	51.18% <50.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/core.py	34.64% <50.00%> (-40.72%)	⬇️
superset/utils/dashboard_import_export.py	0.00% <0.00%> (-100.00%)	⬇️
superset/tags/core.py	4.54% <0.00%> (-95.46%)	⬇️
superset/key_value/commands/update.py	0.00% <0.00%> (-90.91%)	⬇️
superset/key_value/commands/delete.py	0.00% <0.00%> (-87.88%)	⬇️
superset/db_engines/hive.py	0.00% <0.00%> (-85.19%)	⬇️
superset/key_value/commands/delete_expired.py	0.00% <0.00%> (-84.00%)	⬇️
superset/dashboards/commands/importers/v0.py	15.62% <0.00%> (-76.25%)	⬇️
superset/datasets/commands/create.py	30.61% <0.00%> (-69.39%)	⬇️
superset/datasets/commands/update.py	25.00% <0.00%> (-69.05%)	⬇️
... and 284 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[villebro]

LGTM, but I wonder if Airbnb are still using these internally? Ping @john-bodley

[michael-s-molina]

LGTM