-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQLLab] Fix the usage of Redux DevTools Enhancer #1278
Conversation
enhancerWithPersistState = compose( | ||
persistState(), window.devToolsExtension && window.devToolsExtension() | ||
); | ||
const composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this triggers the linter, breaks the build, to fix please add /* eslint-disable no-underscore-dangle */
on the line right above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, fixed.
Nice thanks for the pro-active fix! |
…che#1278) * feat(legacy-preset-chart-big-number): add timestamp above number * add timestamp formatting * revert to fallback warning when no timestamp * fix smart date formatting * fix test Co-authored-by: Ivan Krsnik <ivan.krsnik@unipart.io>
…che#1278) * feat(legacy-preset-chart-big-number): add timestamp above number * add timestamp formatting * revert to fallback warning when no timestamp * fix smart date formatting * fix test Co-authored-by: Ivan Krsnik <ivan.krsnik@unipart.io>
…che#1278) * feat(legacy-preset-chart-big-number): add timestamp above number * add timestamp formatting * revert to fallback warning when no timestamp * fix smart date formatting * fix test Co-authored-by: Ivan Krsnik <ivan.krsnik@unipart.io>
…che#1278) * feat(legacy-preset-chart-big-number): add timestamp above number * add timestamp formatting * revert to fallback warning when no timestamp * fix smart date formatting * fix test Co-authored-by: Ivan Krsnik <ivan.krsnik@unipart.io>
The issue caused by not having the extension installed could be solved by using
However, it was really confusing. So, we're deprecating the enhancer in favour of a more clear API.
I'm happy that Airbnb devs found the extension useful. If you have any other suggestions about it, let me know (since we're both building tools for development).
Fixes #1223, #1228, #1238.