Added alert to install redux devtool #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascott
reviewed
Sep 30, 2016
| persistState(), window.devToolsExtension && window.devToolsExtension() | ||
| ); | ||
| } else { | ||
| console.log('Please kindly install Redux Devtool Extension to use SQL Lab'); |
There was a problem hiding this comment.
we could use console.warn here to get the warning formatting in the console.
also, we may want to generalize the error message since we will soon be using redux in explore view as well.
You may encounter errors unless you have Redux Devtool Extension installed -- https://github.com/zalmoxisus/redux-devtools-extension'
|
great! LGTM. 🚢 |
vera-liu
force-pushed
the
redux_dev_tool_alert
branch
from
12a6639
to
afa6608
Compare
This was referenced Aug 19, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor change
Related: #1223
needs-review: @ascott @bkyryliuk