fix(multiline): return all chart data on initial request #12660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
+ Coverage 64.55% 66.62% +2.06%
==========================================
Files 1018 1018
Lines 49787 49820 +33
Branches 4971 4877 -94
==========================================
+ Hits 32141 33193 +1052
+ Misses 17468 16504 -964
+ Partials 178 123 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
force-pushed
the
villebro/multiline
branch
from
853c71b to
3cd726c
Compare
villebro
changed the title
villebro
changed the title
ktmud
approved these changes
Jan 22, 2021
superset/viz.py
Outdated
| from superset.charts.dao import ChartDAO | ||
|
|
||
| axis1_charts = ChartDAO.find_by_ids(multiline_fd.get("line_charts", [])) | ||
| axis2_charts = ChartDAO.find_by_ids(multiline_fd.get("line_charts_2", [])) |
There was a problem hiding this comment.
It might be possible to combine these two queries into one:
axis1_chart_ids = multiline_fd.get("line_charts", [])
axis2_chart_ids = multiline_fd.get("line_charts_2", [])
all_charts = ChartDAO.find_by_ids(axis1_chart_ids + axis2_chart_ids)
axis1_charts = all_charts[:len(axis1_chart_ids)]
axis2_charts = all_charts[len(axis1_chart_ids):]There was a problem hiding this comment.
I did a slight variation of this to that doesn't fail if there are duplicates (shouldn't be the case, but you never know).
|
@villebro Should I do extra steps to make this working? When I open multiline chart I got this: |
|
@adam-stasiak that's peculiar, I wonder if your frontend assets are properly rebuilt? With the new version of the NVD3 package |
junlincc
added
viz:charts:multiline
|
I rerun npm install and docker and now without an issue:) 🟢 |
junlincc
added
rush!
junlincc
removed
need:merge
villebro
added a commit
that referenced
this pull request
Jan 25, 2021
* fix(multiline): return chart data on data request * bump package * optimize chart retrieval and fix chart form_data
3 tasks
mistercrunch
added
🍒 1.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Move the multiline logic from frontend to backend to avoid multiple requests to the backend that were complicated by async framework. Frontend changes done here: apache-superset/superset-ui#899.
SCREENSHOT
TEST PLAN
Local testing
ADDITIONAL INFORMATION