Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-chart] Legend Keys are displaying incorrectly #12935

Closed
3 tasks done
rwspielman opened this issue Feb 4, 2021 · 5 comments · Fixed by #12937
Closed
3 tasks done

[multi-chart] Legend Keys are displaying incorrectly #12935

rwspielman opened this issue Feb 4, 2021 · 5 comments · Fixed by #12937
Labels
#bug:regression Bugs that are identified as regessions good first issue Good first issues for new contributors viz:charts:multiline Related to the Multiline chart

Comments

@rwspielman
Copy link
Contributor

Looks like this line is the cause

"key": prefix + ", ".join(series["key"]),

Expected results

Legends to show up as normal text

Actual results

chart keys show up as tuples

Screenshots

Screen Shot 2021-02-03 at 11 11 25 PM

How to reproduce the bug

  1. Create 2 charts
  2. make a multi line chart
  3. observe legends keys displaying incorrectly

Environment

(please complete the following information):

  • superset version: master 9fa52d3
  • python version: 3.8
  • node.js version: 12

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

@rwspielman rwspielman added the #bug Bug report label Feb 4, 2021
@rwspielman
Copy link
Contributor Author

#12660

@junlincc junlincc added viz:charts:multiline Related to the Multiline chart good first issue Good first issues for new contributors #bug:regression Bugs that are identified as regessions and removed #bug Bug report labels Feb 4, 2021
@junlincc
Copy link
Member

junlincc commented Feb 4, 2021

@rwspielman thanks for reporting! I was able to reproduce. tagged good first issue
We currently are short for help and if you already have a solution, we absolutely welcome your contribution. 🙏

Screen Shot 2021-02-03 at 9 37 40 PM

@Rishabhraghwendra18
Copy link

Hey!!! May I work on this issue ?

@junlincc
Copy link
Member

junlincc commented Feb 4, 2021

@Rishabhraghwendra18 Absolutely!thank you for contribution in advance! if you are interested in working on more Superset dataviz project, please let me know. apache-superset/superset-roadmap#150 🙏

@Rishabhraghwendra18
Copy link

@junlincc thanks buddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:regression Bugs that are identified as regessions good first issue Good first issues for new contributors viz:charts:multiline Related to the Multiline chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants