fix: chart disappears in standalone slice when resizing #12606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12606 +/- ##
==========================================
- Coverage 65.69% 63.18% -2.51%
==========================================
Files 1015 486 -529
Lines 49651 29982 -19669
Branches 4839 0 -4839
==========================================
- Hits 32618 18945 -13673
+ Misses 16889 11037 -5852
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
duynguyenhoang
force-pushed
the
fix/chart-disappear-standalone-mode
branch
from
b05ff76 to
b1ccd69
Compare
ktmud
reviewed
Jan 19, 2021
| if (props.standalone) { | ||
| // dom manipulation hack to get rid of the boostrap theme's body background | ||
| const standaloneClass = 'background-transparent'; | ||
| const bodyClasses = document.body.className.split(' '); | ||
| if (!bodyClasses.includes(standaloneClass)) { | ||
| document.body.className += ` ${standaloneClass}`; | ||
| } | ||
| return renderChart(); | ||
| return standaloneChartBody; |
There was a problem hiding this comment.
I understand it is for consistency, but memorization is probably not needed here.
There was a problem hiding this comment.
Rendering a single <div> element should be fairly efficient.
ktmud
changed the title
dpgaspar
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 20, 2021
villebro
pushed a commit
that referenced
this pull request
Jan 25, 2021
mistercrunch
added
🍒 1.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add
refto standalone chart renderTEST PLAN
ADDITIONAL INFORMATION