Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone embedded charts don't render in iframes #12612

Closed
etr2460 opened this issue Jan 20, 2021 · 5 comments
Closed

Standalone embedded charts don't render in iframes #12612

etr2460 opened this issue Jan 20, 2021 · 5 comments
Labels
#bug:regression Bugs that are identified as regessions !deprecated-label:viz:explore:others Deprecated label - Use explore instead explore Namespace | Anything related to Explore

Comments

@etr2460
Copy link
Member

etr2460 commented Jan 20, 2021

When embedding a chart in an iframe with the standalone=true param, it doesn't render

Expected results

See the full chart with no sidebar

Actual results

See nothing

How to reproduce the bug

  1. Click the embed button for a chart in explore
  2. Copy the iframe code and put on a webpage
  3. See nothing

Environment

  • superset version: master

Additional context

Note that the whole page renders when used in an iframe, so this only happens when the standalone param is used. I suspect it was caused by the new sidebar added to explore or one of the other redesigns.

cc @zuzana-vej

@etr2460 etr2460 added explore Namespace | Anything related to Explore #bug Bug report !deprecated-label:viz:explore:others Deprecated label - Use explore instead #bug:regression Bugs that are identified as regessions labels Jan 20, 2021
@junlincc
Copy link
Member

related: #12557

@junlincc junlincc removed the #bug Bug report label Jan 20, 2021
@dpgaspar
Copy link
Member

@etr2460 can you check that this was fixed with: #12606 ?

@etr2460
Copy link
Member Author

etr2460 commented Jan 20, 2021

Will verify after today's release, thanks!

@etr2460
Copy link
Member Author

etr2460 commented Jan 21, 2021

Yup, this fixed it. Thanks!

@etr2460 etr2460 closed this as completed Jan 21, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

@etr2460

I used the upgrade command to upgrade to the latest version, but this problem still occurs, how did you solve it?
pip install apache-superset --upgrade
superset db upgrade
superset init

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:regression Bugs that are identified as regessions !deprecated-label:viz:explore:others Deprecated label - Use explore instead explore Namespace | Anything related to Explore
Projects
None yet
Development

No branches or pull requests

3 participants