fix: row component handler is visible

[kkucharc]

SUMMARY

In dashboard's edit mode menu with delete and move on left was cut by left end of page/browser.
I made equal margin on both sides. The menu is closer the edited row.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Left margin was more narrow than right one.

Menu with move and delete in dashboard edit was truncated:

After:
Without native filters:
Preview mode:

Edit mode:

With native filters:
Preview mode:

Edit mode:

TEST PLAN

1. Go to any dashboard and check margins
   1a. Go to edit mode of dashboard and try edit row of dashboard (on left there will be icon to delete or to move chart)

To test native filters:
Go to supserset/config.py and change "DASHBOARD_NATIVE_FILTERS": False, -> "DASHBOARD_NATIVE_FILTERS": True,

ADDITIONAL INFORMATION

• Has associated issue: close: [Dashboard] Row component handler is truncated  #12481
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

cc: @agatapst Can you take a look? I made some changes in your code.
cc: @junlincc @adam-stasiak

[codecov-io]

Codecov Report

Merging #12498 (5fdbd57) into master (2d10a2c) will decrease coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #12498      +/-   ##
==========================================
- Coverage   62.66%   62.36%   -0.30%     
==========================================
  Files        1014     1015       +1     
  Lines       49593    49606      +13     
  Branches     4839     4839              
==========================================
- Hits        31075    30938     -137     
- Misses      18320    18470     +150     
  Partials      198      198              

Flag	Coverage Δ
javascript	60.73% <100.00%> (+<0.01%)	⬆️
python	63.43% <ø> (-0.49%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...tend/src/dashboard/components/DashboardBuilder.jsx	76.54% <100.00%> (ø)
superset/db_engines/hive.py	0.00% <0.00%> (-85.72%)	⬇️
superset/db_engine_specs/hive.py	54.61% <0.00%> (-29.24%)	⬇️
superset/db_engine_specs/presto.py	70.56% <0.00%> (-11.48%)	⬇️
superset/views/database/mixins.py	80.70% <0.00%> (-1.76%)	⬇️
superset/models/core.py	88.04% <0.00%> (-0.82%)	⬇️
superset/db_engine_specs/solr.py	100.00% <0.00%> (ø)
...rset-frontend/src/explore/components/SaveModal.tsx	86.04% <0.00%> (+0.16%)	⬆️
superset/db_engine_specs/pinot.py	70.73% <0.00%> (+2.31%)	⬆️
superset/db_engine_specs/postgres.py	96.05% <0.00%> (+9.21%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70db43...5fdbd57. Read the comment docs.

[ktmud]

How does it look like when the native filter is expanded?

I filed a related bug report yesterday: #12486

[adam-stasiak]

@ktmud looks lite this:

looks fine to me.

[agatapst]

@kkucharc regarding native filters:

• when Filter Bar is hidden, the sidebar should look the same in Dashboard page and Explore page and it does 👍
  Explore sidebar:
  
  Dashboard sidebar:
  

• when Filter Bar is open:
  in your PR:
  

master:

I can see there is bigger distance between Filter Bar and Dashboard in your PR, but in my opinion both versions look just fine. 🙂 If the cost of smaller distance between Native Filter Bar and Dashboard are UI issues in some other component, then I am fine with it.

[junlincc]

can we have the icons perfectly centered in the page by adding more padding on the right side? @kkucharc

[rusackas]

Code LGTM! Nice and simple. @junlincc 's question is a good one, so I'll leave this open in case you want to increase the gutter between the icons and charts a bit before merging.

[kkucharc]

Thanks @rusackas @junlincc for the test and review. I centered horizontally those icons, rebased and removed IMO redundant (top-bottom) padding. Now it looks like this:

[junlincc]

LGTM, please disregard my last comment. thanks for the fix!