Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] native filter and dashboard edit mode #12486

Closed
ktmud opened this issue Jan 13, 2021 · 4 comments
Closed

[Dashboard] native filter and dashboard edit mode #12486

ktmud opened this issue Jan 13, 2021 · 4 comments
Assignees
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed dashboard:editmode Related to te Dashboard edit mode dashboard:native-filters Related to the native filters of the Dashboard

Comments

@ktmud
Copy link
Member

ktmud commented Jan 13, 2021

Screenshot

A couple of cosmetic issues with dashboard edit mode and native filters:

Card controls is cramped with the native filter container.

Snip20210112_126

Drop indicators are a little off. Both position-wise and length-wise.

Snip20210112_127

@ktmud ktmud added dashboard:editmode Related to te Dashboard edit mode dashboard:native-filters Related to the native filters of the Dashboard labels Jan 13, 2021
@junlincc junlincc added the #bug:cosmetic Cosmetic/layout/design tweak needed label Jan 13, 2021
@kkucharc kkucharc self-assigned this Jan 14, 2021
@kkucharc
Copy link
Contributor

Hi @ktmud as you mentioned fix: row component handler is visible #12498 addresses the first issue with icons. I just added PR for the rest.

I've got 2 additional questions.

  1. I am wondering if this indicator line is in correct place?
    Screenshot_2021-01-18_at_18_03_16__2_

  2. Should this right indicator behave like this (disappear only when we move cursor to the top or bottom?)
    Large GIF (1068x574)

@junlincc
Copy link
Member

junlincc commented Jan 18, 2021

  1. The line should show when the top of the card is getting close to the row, and when the left side of the card is getting close to the column, instead of half way through

  2. Users should be 1. only seeing one horizontal line to indicate the row position. 2.only seeing one vertical line to indicate the column position. 3. one horizontal line + one vertical line on the left that create top left corner to indicate the exact position.
    but again, line shows when the border of the card gets close, not half way through. I believe.

@kkucharc

ktmud thoughts?
Screen Shot 2021-01-18 at 10 16 58 AM

@ktmud
Copy link
Member Author

ktmud commented Jan 18, 2021

  1. The indicator line preferably should show at least below the bottom border of the current tab.
  2. The indicator line should only show at where the dragged element will be placed when users release the drag & drop. Therefore the right indicator should not display if releasing the dragged component does not put it into the right column.

@kkucharc
Copy link
Contributor

I will open separate PRs for those improvements just to make those changes small and easy revertable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed dashboard:editmode Related to te Dashboard edit mode dashboard:native-filters Related to the native filters of the Dashboard
Projects
None yet
Development

No branches or pull requests

3 participants