Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change order of tab on explore data panel #12335

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Jan 7, 2021

SUMMARY

  • show metrics before columns on explore data panel

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After
https://www.loom.com/share/b8c248ca475a493c9d8925a91c086d45

TEST PLAN

ADDITIONAL INFORMATION

@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #12335 (995ce5a) into master (076c31d) will decrease coverage by 3.67%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12335      +/-   ##
==========================================
- Coverage   66.60%   62.92%   -3.68%     
==========================================
  Files        1002     1001       -1     
  Lines       49330    49367      +37     
  Branches     5020     5033      +13     
==========================================
- Hits        32855    31065    -1790     
- Misses      16333    18095    +1762     
- Partials      142      207      +65     
Flag Coverage Δ
cypress ?
javascript 60.99% <0.00%> (-0.19%) ⬇️
python 64.18% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/explore/components/DatasourcePanel.tsx 85.36% <0.00%> (-4.88%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/components/Hotkeys.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (-100.00%) ⬇️
...tend/src/dashboard/containers/DashboardBuilder.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076c31d...995ce5a. Read the comment docs.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junlincc junlincc added the explore:datapanel Related to the Data panel of Explore label Jan 7, 2021
@adam-stasiak
Copy link
Contributor

OK for me after test!

@junlincc junlincc self-requested a review January 7, 2021 22:57
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!
ezgif-7-042034e00752

@lilykuang, could you please make sure the changes made in fix(explore): metrics caret not expanding in datasource panel are captured in your PR? - both sections open by default.

not ready to merge yet.

Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezgif-7-38ff703f1fd1

tested again, both section open by default. approving

@ktmud ktmud merged commit 6276421 into apache:master Jan 8, 2021
@lilykuang lilykuang deleted the lily/change-datapanel-order-content branch August 30, 2022 16:26
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:datapanel Related to the Data panel of Explore preset-io size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants