-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change order of tab on explore data panel #12335
chore: change order of tab on explore data panel #12335
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12335 +/- ##
==========================================
- Coverage 66.60% 62.92% -3.68%
==========================================
Files 1002 1001 -1
Lines 49330 49367 +37
Branches 5020 5033 +13
==========================================
- Hits 32855 31065 -1790
- Misses 16333 18095 +1762
- Partials 142 207 +65
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
OK for me after test! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lilykuang, could you please make sure the changes made in fix(explore): metrics caret not expanding in datasource panel are captured in your PR? - both sections open by default.
not ready to merge yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
https://www.loom.com/share/b8c248ca475a493c9d8925a91c086d45
TEST PLAN
ADDITIONAL INFORMATION