Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore] datapanel: order of content section #12316

Closed
graceguo-supercat opened this issue Jan 6, 2021 · 5 comments
Closed

[explore] datapanel: order of content section #12316

graceguo-supercat opened this issue Jan 6, 2021 · 5 comments
Labels
explore:datapanel Related to the Data panel of Explore P1 Priority item - Major

Comments

@graceguo-supercat
Copy link

Screenshots

Screen_Shot_2021-01-06_at_1_56_49_PM

  • in datapanel, it shows COLUMNS before METRICS
  • in dataset editor, COLUMNS tab is after METRICS

Can we show METRICS before COLUMNS in datapanel?

Environment

latest master

cc @junlincc

@graceguo-supercat graceguo-supercat added P1 Priority item - Major explore:datapanel Related to the Data panel of Explore #bug Bug report labels Jan 6, 2021
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@graceguo-supercat graceguo-supercat removed the #bug Bug report label Jan 6, 2021
@junlincc junlincc added data:dataset Related to dataset configurations data:dataset:edit and removed explore:datapanel Related to the Data panel of Explore data:dataset Related to dataset configurations labels Jan 6, 2021
@junlincc junlincc added explore:datapanel Related to the Data panel of Explore and removed data:dataset:edit labels Jan 7, 2021
@graceguo-supercat
Copy link
Author

graceguo-supercat commented Jan 7, 2021

This change is small. But may i know why you choose to change the order in dataset editor, instead of datapanel?
In my opinion, dataset editor has been there for year(s). Users knows the order of each tab. For active users, they may check dataset everyday. While datapanel is something very new, probably no real users yet.
If you prefer to change an existed behavior, may i know what is the advantage or necessity to make this change? cc @junlincc @lilykuang

@junlincc
Copy link
Member

junlincc commented Jan 7, 2021

Can we show METRICS before COLUMNS in datapanel?

we are making the change on data panel, moving METRICS about COLUMNS, please checkout #12335

@graceguo-supercat
Copy link
Author

oh sorry....i misunderstood "tab" in the PR title 😢. Thank you so much! @junlin and @lilykuang

@junlincc
Copy link
Member

junlincc commented Jan 8, 2021

done, closing! thank you @lilykuang again for the quick fix!

@junlincc junlincc closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explore:datapanel Related to the Data panel of Explore P1 Priority item - Major
Projects
None yet
Development

No branches or pull requests

2 participants