-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-50107][SQL][BUILD] Upgrade protobuf-java
to 4.28.3
#48646
Conversation
To @HyukjinKwon and @grundprinzip , WDYT? I believe Apache Spark 4 is the last chance to take this kind of change because it's hard to image Apache Spark 5 in next 4 years. |
All tests passed. |
cc @hvanhovell too |
@@ -217,12 +217,12 @@ public interface StateRequestOrBuilder extends | |||
* Protobuf type {@code org.apache.spark.sql.execution.streaming.state.StateRequest} | |||
*/ | |||
public static final class StateRequest extends | |||
com.google.protobuf.GeneratedMessageV3 implements | |||
com.google.protobuf.GeneratedMessage implements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted a PR to change to use maven/sbt
plugin to generation this file: #48654
I think that makes sense, is this a recent version or do we need to upgrade even more? |
To @grundprinzip , this is the latest version which is released two days ago (Oct 23, 2024). To @LuciferYang , thanks. Let's review and handle your PR after merging this. |
Thank you, @HyukjinKwon , @LuciferYang , @grundprinzip . Merged to master for Apache Spark 4.0.0 on February 2025. |
@dongjoon-hyun It seems that after this pr, the Before:
After:
The Maven daily tests for the past two days have all failed to compile, and I haven't found the root cause yet: |
Thank you for reporting. Let me check, @LuciferYang . |
According to the log message string |
Let me try the workaround, |
What changes were proposed in this pull request?
This PR aims to upgrade
protobuf-java
to 4.28.3 for Apache Spark 4.0.0 on February 2025.Why are the changes needed?
protobuf-java
4.28.3
is the latest version which is released two days ago (Oct 23, 2024).https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java/4.28.3
This is a part of
v28.3
.Note that
v26
introduced a breaking change to Java API last year.Does this PR introduce any user-facing change?
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.