Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50106][PYTHON] Upgrade protobuf Python package to 5.28.3 #48644

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Oct 24, 2024

What changes were proposed in this pull request?

This PR aims to upgrade protobuf Python package from 4.25.1 to 5.28.3 for Apache Spark 4.0.0 on February 2025.

Why are the changes needed?

To bring the latest bug fixes and support Python 3.13 which requires grpcio*>=1.66.2 (grpcio-status>=1.66.2 requires protobuf>=5.26.1).

Does this PR introduce any user-facing change?

This is a dependency change with no behavior change.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-50106][PYTHON] Upgrade protobuf Python package to 5.28.3 [SPARK-50106][BUILD] Upgrade protobuf Python package to 5.28.3 and protobuf-java to 4.28.3 Oct 24, 2024
@dongjoon-hyun dongjoon-hyun marked this pull request as draft October 24, 2024 20:58
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-50106][BUILD] Upgrade protobuf Python package to 5.28.3 and protobuf-java to 4.28.3 [SPARK-50106][BUILD] Upgrade protobuf Python package to 5.28.3 Oct 24, 2024
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review October 24, 2024 21:03
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-50106][BUILD] Upgrade protobuf Python package to 5.28.3 [SPARK-50106][PYTHON] Upgrade protobuf Python package to 5.28.3 Oct 24, 2024
@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Oct 24, 2024

cc @HyukjinKwon
This is intentionally focusing on Python side only. For Java-side, we have a separate PR for further discussion.

@dongjoon-hyun
Copy link
Member Author

All tests passed.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR too, @zhengruifeng and @xinrong-meng ?

@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @viirya ?

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon . Merged to master for Apache Spark 4.0.0 on February 2025.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-50106 branch October 25, 2024 13:59
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants