Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-46002][INFRA] Upgrade to Python 3.9 in SQL test #43902

Closed
wants to merge 3 commits into from

Conversation

zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented Nov 20, 2023

What changes were proposed in this pull request?

Upgrade to Python 3.9 in SQL test

Why are the changes needed?

this version has not been upgraded in more than 3 years

Does this PR introduce any user-facing change?

no, test-only

How was this patch tested?

ci

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the INFRA label Nov 20, 2023
@zhengruifeng zhengruifeng marked this pull request as draft November 20, 2023 06:21
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but Python 3.8 is still a version of supported.
If we need to upgrade the default Python test version, it should be consistent with PySpark, @zhengruifeng .

@zhengruifeng
Copy link
Contributor Author

Sorry, but Python 3.8 is still a version of supported. If we need to upgrade the default Python test version, it should be consistent with PySpark, @zhengruifeng .

yeah, let me switch to 3.9 to be consistent first.

@dongjoon-hyun
Copy link
Member

Thank you! Python 3.9 sounds good.

@zhengruifeng zhengruifeng changed the title [SPARK-46002][INFRA] Upgrade to Python 3.10 in SQL test [SPARK-46002][INFRA] Upgrade to Python 3.9 in SQL test Nov 20, 2023
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating. Pending Draft and CI.

@zhengruifeng zhengruifeng marked this pull request as ready for review November 20, 2023 12:19
@zhengruifeng
Copy link
Contributor Author

also cc @HyukjinKwon

@dongjoon-hyun
Copy link
Member

Merged to master. Thank you, @zhengruifeng .

@zhengruifeng zhengruifeng deleted the infra_sql_py310 branch November 21, 2023 00:08
zhengruifeng added a commit that referenced this pull request Nov 23, 2023
### What changes were proposed in this pull request?
Upgrade to Python 3.9 in daily maven test

### Why are the changes needed?
to be consistent with #43902

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
ci

### Was this patch authored or co-authored using generative AI tooling?
no

Closes #43975 from zhengruifeng/infra_sql_py_followup.

Authored-by: Ruifeng Zheng <ruifengz@apache.org>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants