Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][connector-jdbc] Calculate splits only once in JdbcSourceSplitEnumerator #2900

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

zhaomin1423
Copy link
Member

Purpose of this pull request

Calculate splits every time when registerReader() .

Check list

@zhaomin1423
Copy link
Member Author

cc @Hisoka-X

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ic4y PTAL.

Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 merged commit 7622f28 into apache:dev Sep 26, 2022
Hisoka-X added a commit that referenced this pull request Oct 27, 2022
* seatunnel-metrics init commit

* seatunnel-metrics config add

* codeStyle update

* codeStyle update again

* codeStyle seatunnel-spark update

* [Imporve][Connector-V2]Parameter verification for connector V2 kafka sink (#2866)

* parameter verification

* update

* update

* [Improve][DOC] Perfect the connector v2 doc (#2800)

* [Improve][DOC] Perfect the connector v2 doc

* Update seatunnel-connectors-v2/README.zh.md

Co-authored-by: Hisoka <fanjiaeminem@qq.com>

* [Improve][DOC] A little tinkering

* [Improve][DOC] A little tinkering

* [Doc][connector] add Console sink doc

close #2794

* [Doc][connector] add Console sink doc

close #2794

* fix some problem

* fix some problem

* fine tuning

Co-authored-by: Hisoka <fanjiaeminem@qq.com>

* add seatunnel-examples from gitignore (#2892)

* [Improve][connector-jdbc] Calculate splits only once in JdbcSourceSplitEnumerator (#2900)

* [Bug][Connector-V2] Fix wechat sink data serialization (#2856)

* [Improve][Connector-V2] Improve orc write strategy to support all data types (#2860)

* [Improve][Connector-V2] Improve orc write strategy to support all data types

Co-authored-by: tyrantlucifer <tyrantlucifer@gmail.com>

* [Bug][seatunnel-translation-base] Fix Source restore state NPE (#2878)

* [Improve][Connector-v2-Fake]Supports direct definition of data values(row) (#2839)

* [Improve][Connector-v2]Supports direct definition of data values(row)

* seatunnel-prometheus update

* seatunnel-prometheus update

* seatunnel-prometheus update

* 1. Seatunnel unified configuration naming
2. Use reflection to automate assembly
3. Modify the flink/spark startup function
4. Try packaging configuration (todo)

Co-authored-by: TaoZex <45089228+TaoZex@users.noreply.github.com>
Co-authored-by: liugddx <804167098@qq.com>
Co-authored-by: Hisoka <fanjiaeminem@qq.com>
Co-authored-by: Eric <gaojun2048@gmail.com>
Co-authored-by: Xiao Zhao <zhaomin1423@163.com>
Co-authored-by: hailin0 <wanghailin@apache.org>
Co-authored-by: tyrantlucifer <tyrantlucifer@gmail.com>
Co-authored-by: Laglangyue <35491928+laglangyue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants