-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Imporve][Connector-V2]Parameter verification for connector V2 kafka sink #2866
Conversation
@@ -136,7 +136,7 @@ private Properties getKafkaProperties(Config pluginConfig) { | |||
|
|||
// todo: parse the target field from config | |||
private SeaTunnelRowSerializer<byte[], byte[]> getSerializer(Config pluginConfig, SeaTunnelRowType seaTunnelRowType) { | |||
return new DefaultSeaTunnelRowSerializer(pluginConfig.getString("topics"), seaTunnelRowType); | |||
return new DefaultSeaTunnelRowSerializer(pluginConfig.getString("topic"), seaTunnelRowType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change it to use static String TOPIC
maybe better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thans,i will modify it.
#2863 This pr does not conflict with the current pr, because this is the doc of the connector V1 version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the community have the code style required? I use the code style format that comes with IDEA, which cannot pass the CI pipeline.Thank you for your help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the code format and submitted it again, please reopen the CI pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Network problem, I will rerun it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* seatunnel-metrics init commit * seatunnel-metrics config add * codeStyle update * codeStyle update again * codeStyle seatunnel-spark update * [Imporve][Connector-V2]Parameter verification for connector V2 kafka sink (#2866) * parameter verification * update * update * [Improve][DOC] Perfect the connector v2 doc (#2800) * [Improve][DOC] Perfect the connector v2 doc * Update seatunnel-connectors-v2/README.zh.md Co-authored-by: Hisoka <fanjiaeminem@qq.com> * [Improve][DOC] A little tinkering * [Improve][DOC] A little tinkering * [Doc][connector] add Console sink doc close #2794 * [Doc][connector] add Console sink doc close #2794 * fix some problem * fix some problem * fine tuning Co-authored-by: Hisoka <fanjiaeminem@qq.com> * add seatunnel-examples from gitignore (#2892) * [Improve][connector-jdbc] Calculate splits only once in JdbcSourceSplitEnumerator (#2900) * [Bug][Connector-V2] Fix wechat sink data serialization (#2856) * [Improve][Connector-V2] Improve orc write strategy to support all data types (#2860) * [Improve][Connector-V2] Improve orc write strategy to support all data types Co-authored-by: tyrantlucifer <tyrantlucifer@gmail.com> * [Bug][seatunnel-translation-base] Fix Source restore state NPE (#2878) * [Improve][Connector-v2-Fake]Supports direct definition of data values(row) (#2839) * [Improve][Connector-v2]Supports direct definition of data values(row) * seatunnel-prometheus update * seatunnel-prometheus update * seatunnel-prometheus update * 1. Seatunnel unified configuration naming 2. Use reflection to automate assembly 3. Modify the flink/spark startup function 4. Try packaging configuration (todo) Co-authored-by: TaoZex <45089228+TaoZex@users.noreply.github.com> Co-authored-by: liugddx <804167098@qq.com> Co-authored-by: Hisoka <fanjiaeminem@qq.com> Co-authored-by: Eric <gaojun2048@gmail.com> Co-authored-by: Xiao Zhao <zhaomin1423@163.com> Co-authored-by: hailin0 <wanghailin@apache.org> Co-authored-by: tyrantlucifer <tyrantlucifer@gmail.com> Co-authored-by: Laglangyue <35491928+laglangyue@users.noreply.github.com>
Purpose of this pull request
issue:#2802
The first change is because the connector V2 kafka sink has no config check, so it is checked.
The second change is for the uniformity of use. The previous sink parameter configuration is called topics, and the source parameter configuration is called topic, which has been changed to topic for unification.
Check list
New License Guide