[Imporve][Connector-V2]Parameter verification for connector V2 kafka sink #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Sep 23, 2022
| @@ -136,7 +136,7 @@ private Properties getKafkaProperties(Config pluginConfig) { | |||
|
|
|||
| // todo: parse the target field from config | |||
| private SeaTunnelRowSerializer<byte[], byte[]> getSerializer(Config pluginConfig, SeaTunnelRowType seaTunnelRowType) { | |||
| return new DefaultSeaTunnelRowSerializer(pluginConfig.getString("topics"), seaTunnelRowType); | |||
| return new DefaultSeaTunnelRowSerializer(pluginConfig.getString("topic"), seaTunnelRowType); | |||
There was a problem hiding this comment.
Change it to use static String TOPIC maybe better.
There was a problem hiding this comment.
Thans,i will modify it.
#2863 This pr does not conflict with the current pr, because this is the doc of the connector V1 version.
There was a problem hiding this comment.
Does the community have the code style required? I use the code style format that comes with IDEA, which cannot pass the CI pipeline.Thank you for your help.
There was a problem hiding this comment.
There was a problem hiding this comment.
I checked the code format and submitted it again, please reopen the CI pipeline.
There was a problem hiding this comment.
Is this a CI pipeline problem?
There was a problem hiding this comment.
Network problem, I will rerun it.
Hisoka-X
approved these changes
Sep 26, 2022
Hisoka-X
added a commit
that referenced
this pull request
Oct 27, 2022
* seatunnel-metrics init commit * seatunnel-metrics config add * codeStyle update * codeStyle update again * codeStyle seatunnel-spark update * [Imporve][Connector-V2]Parameter verification for connector V2 kafka sink (#2866) * parameter verification * update * update * [Improve][DOC] Perfect the connector v2 doc (#2800) * [Improve][DOC] Perfect the connector v2 doc * Update seatunnel-connectors-v2/README.zh.md Co-authored-by: Hisoka <fanjiaeminem@qq.com> * [Improve][DOC] A little tinkering * [Improve][DOC] A little tinkering * [Doc][connector] add Console sink doc close #2794 * [Doc][connector] add Console sink doc close #2794 * fix some problem * fix some problem * fine tuning Co-authored-by: Hisoka <fanjiaeminem@qq.com> * add seatunnel-examples from gitignore (#2892) * [Improve][connector-jdbc] Calculate splits only once in JdbcSourceSplitEnumerator (#2900) * [Bug][Connector-V2] Fix wechat sink data serialization (#2856) * [Improve][Connector-V2] Improve orc write strategy to support all data types (#2860) * [Improve][Connector-V2] Improve orc write strategy to support all data types Co-authored-by: tyrantlucifer <tyrantlucifer@gmail.com> * [Bug][seatunnel-translation-base] Fix Source restore state NPE (#2878) * [Improve][Connector-v2-Fake]Supports direct definition of data values(row) (#2839) * [Improve][Connector-v2]Supports direct definition of data values(row) * seatunnel-prometheus update * seatunnel-prometheus update * seatunnel-prometheus update * 1. Seatunnel unified configuration naming 2. Use reflection to automate assembly 3. Modify the flink/spark startup function 4. Try packaging configuration (todo) Co-authored-by: TaoZex <45089228+TaoZex@users.noreply.github.com> Co-authored-by: liugddx <804167098@qq.com> Co-authored-by: Hisoka <fanjiaeminem@qq.com> Co-authored-by: Eric <gaojun2048@gmail.com> Co-authored-by: Xiao Zhao <zhaomin1423@163.com> Co-authored-by: hailin0 <wanghailin@apache.org> Co-authored-by: tyrantlucifer <tyrantlucifer@gmail.com> Co-authored-by: Laglangyue <35491928+laglangyue@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
issue：#2802
The first change is because the connector V2 kafka sink has no config check, so it is checked.
The second change is for the uniformity of use. The previous sink parameter configuration is called topics, and the source parameter configuration is called topic, which has been changed to topic for unification.
Check list
New License Guide