Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][e2e] connectors e2e use separate module #2648

Merged
merged 2 commits into from
Sep 6, 2022
Merged

[Improve][e2e] connectors e2e use separate module #2648

merged 2 commits into from
Sep 6, 2022

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Sep 5, 2022

Purpose of this pull request

close #2607

Check list

ashulin
ashulin reviewed Sep 5, 2022
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@hailin0
Copy link
Member Author

hailin0 commented Sep 6, 2022

reference
https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html
https://maven.apache.org/plugins/maven-jar-plugin/test-jar-mojo.html#skip
https://issues.apache.org/jira/browse/MJAR-138

@hailin0
Copy link
Member Author

hailin0 commented Sep 6, 2022

please help to review
@ashulin @Hisoka-X @EricGao888 @CalvinKirs @TyrantLucifer @2013650523 @531651225 @laglangyue @iture123

EricJoy2048
EricJoy2048 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TyrantLucifer
TyrantLucifer approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Hisoka-X
Hisoka-X approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X merged commit 617f6c3 into apache:dev Sep 6, 2022
@531651225 531651225 mentioned this pull request Sep 7, 2022
Closed
3 tasks
@hailin0 hailin0 mentioned this pull request Sep 7, 2022
Merged
3 tasks
@hailin0 hailin0 deleted the Improve-e2e branch September 8, 2022 13:13
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 8, 2022
@hailin0 @MRYOG
[Improve][e2e] connectors e2e use separate module (apache#2648)
582de4e 
* [Improve][e2e] connectors e2e use separate module

* fix
laglangyue pushed a commit to laglangyue/seatunnel that referenced this pull request Sep 11, 2022
@hailin0
[Improve][e2e] connectors e2e use separate module (apache#2648)
e8df21e 
* [Improve][e2e] connectors e2e use separate module

* fix
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 15, 2022
@hailin0 @MRYOG
[Improve][e2e] connectors e2e use separate module (apache#2648)
3ebdafe 
* [Improve][e2e] connectors e2e use separate module

* fix
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 16, 2022
@hailin0 @MRYOG
[Improve][e2e] connectors e2e use separate module (apache#2648)
36554c6 
* [Improve][e2e] connectors e2e use separate module

* fix
TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
@hailin0 @TyrantLucifer
[Improve][e2e] connectors e2e use separate module (apache#2648)
169e132 
* [Improve][e2e] connectors e2e use separate module

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashulin ashulin ashulin left review comments

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][e2e] connectors e2e use separate module
6 participants
@hailin0 @CalvinKirs @EricJoy2048 @Hisoka-X @ashulin @TyrantLucifer