[Feature][Connector-V2] oracle connector #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give a quick review of #2250 review? Some places have not been modified |
|
@CalvinKirs flink e2e fake2oracle is ok |
|
CI is error. how do i fix it? |
maven network connection error, I rerun again. |
CalvinKirs
reviewed
Aug 30, 2022
CalvinKirs
reviewed
Aug 30, 2022
...org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oracle/OracleTypeMapper.java
Outdated
Show resolved
Hide resolved
|
CI is error ,and the error is JdbcPhoenixIT .@CalvinKirs |
|
Hi, rerun, due to its large size
On 08/31/2022 ***@***.***> wrote：
CI is error ,and the error is JdbcPhoenixIT .@CalvinKirs
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
CI is not stable. @CalvinKirs |
hailin0
reviewed
Sep 1, 2022
...link-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcOracleIT.java
Outdated
Show resolved
Hide resolved
...link-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcOracleIT.java
Outdated
Show resolved
Hide resolved
...link-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcOracleIT.java
Outdated
Show resolved
Hide resolved
...link-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcOracleIT.java
Outdated
Show resolved
Hide resolved
liugddx
requested review from
hailin0 and
CalvinKirs
and removed request for
hailin0
hailin0
reviewed
Sep 2, 2022
...park-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/spark/v2/jdbc/JdbcOracleIT.java
Outdated
Show resolved
Hide resolved
...link-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcOracleIT.java
Outdated
Show resolved
Hide resolved
...link-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcOracleIT.java
Outdated
Show resolved
Hide resolved
...park-connector-v2-e2e/src/test/java/org/apache/seatunnel/e2e/spark/v2/jdbc/JdbcOracleIT.java
Outdated
Show resolved
Hide resolved
@CalvinKirs pls review. |
liugddx
requested review from
CalvinKirs and
hailin0
and removed request for
hailin0 and
CalvinKirs
Hisoka-X
reviewed
Sep 5, 2022
|
Need to merge #2648 |
hailin0
reviewed
Sep 7, 2022
| <groupId>com.oracle.database.jdbc</groupId> | ||
| <artifactId>ojdbc8</artifactId> | ||
| <version>${oracle.version}</version> | ||
| <scope>test</scope> |
|
@ic4y @EricJoy2048 @Hisoka-X @hailin0 please help to review ,and rerun CI.Thanks |
|
Already add oracle doc. @EricJoy2048 |
3 tasks
hailin0
reviewed
Oct 8, 2022
...or-jdbc-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcOracledbIT.java
Outdated
Show resolved
Hide resolved
…c/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcOracledbIT.java Co-authored-by: hailin0 <hailin088@gmail.com>
|
Please merge the dev branch to your branch and push again because #3022 |
Done. |
|
merge #3031. fix the e2e error. @EricJoy2048 help to rerun CI,and i need the common part of the jdbc e2e for gbase 8a,thanks |
Hisoka-X
approved these changes
Oct 9, 2022
CalvinKirs
approved these changes
Oct 9, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2548
Purpose of this pull request
new v2 connector for oracle
Check list
New License Guide