Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2] oracle connector #2550

Merged
merged 23 commits into from
Oct 9, 2022
Merged

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Aug 28, 2022

close #2548

Purpose of this pull request

new v2 connector for oracle

Check list

@liugddx
Copy link
Member Author

liugddx commented Aug 28, 2022

#2550

@CalvinKirs
Copy link
Member

Can you give a quick review of #2250 review? Some places have not been modified

@liugddx
Copy link
Member Author

liugddx commented Aug 29, 2022

@CalvinKirs flink e2e fake2oracle is ok

@liugddx
Copy link
Member Author

liugddx commented Aug 30, 2022

CI is error. how do i fix it?

@CalvinKirs
Copy link
Member

CI is error. how do i fix it?

maven network connection error, I rerun again.

pom.xml Outdated Show resolved Hide resolved
@liugddx
Copy link
Member Author

liugddx commented Aug 31, 2022

CI is error ,and the error is JdbcPhoenixIT .@CalvinKirs

@CalvinKirs
Copy link
Member

CalvinKirs commented Aug 31, 2022 via email

@liugddx
Copy link
Member Author

liugddx commented Aug 31, 2022

CI is not stable. @CalvinKirs

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add spark e2e-testcase ?

@liugddx liugddx requested review from hailin0 and CalvinKirs and removed request for hailin0 September 1, 2022 15:32
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liugddx liugddx requested review from hailin0 and removed request for CalvinKirs September 2, 2022 05:54
@liugddx
Copy link
Member Author

liugddx commented Sep 3, 2022

LGTM @CalvinKirs

@CalvinKirs pls review.

@liugddx liugddx requested review from CalvinKirs and hailin0 and removed request for hailin0 and CalvinKirs September 3, 2022 02:46
pom.xml Outdated Show resolved Hide resolved
@hailin0
Copy link
Member

hailin0 commented Sep 7, 2022

Need to merge #2648

<groupId>com.oracle.database.jdbc</groupId>
<artifactId>ojdbc8</artifactId>
<version>${oracle.version}</version>
<scope>test</scope>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use provided?

@liugddx liugddx marked this pull request as ready for review October 8, 2022 02:09
@liugddx
Copy link
Member Author

liugddx commented Oct 8, 2022

@ic4y @EricJoy2048 @Hisoka-X @hailin0 please help to review ,and rerun CI.Thanks

@liugddx
Copy link
Member Author

liugddx commented Oct 8, 2022

Already add oracle doc. @EricJoy2048

EricJoy2048
EricJoy2048 previously approved these changes Oct 8, 2022
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

…c/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcOracledbIT.java

Co-authored-by: hailin0 <hailin088@gmail.com>
@EricJoy2048
Copy link
Member

Please merge the dev branch to your branch and push again because #3022

@liugddx
Copy link
Member Author

liugddx commented Oct 8, 2022

Please merge the dev branch to your branch and push again because #3022

Done.

@liugddx
Copy link
Member Author

liugddx commented Oct 9, 2022

merge #3031. fix the e2e error. @EricJoy2048 help to rerun CI,and i need the common part of the jdbc e2e for gbase 8a,thanks

Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Connector-V2] oracle connector
6 participants