Misc updates + lang3.StringEscapeUtils deprecation + stylesheet edit action fix #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- small optimizations on the fast path of PageServlet - better initial size for StringBuilders; resize won't be needed for most keys. - replaced String append with char append for single char Strings; should be easier to inline
cleaned up some exclusions which didn't do anything anymore.
…ction. - commit 48e9708 only implemented isSharedTheme() branch - added else branch for custom themes - used the opportunity clean the method up
….StringEscapeUtils.
|
rebased on top of latest master + removed a commit which has been already merged via another PR. |
snoopdave
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on PR #69 (update: now integrated)
This PR contains smaller updates and a bugfix: