Fix for dusty integration tests #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the pom was broken possibly from a merge conflict from some time ago - fixed some paths and dependencies - adapted for firefox driver api changes - some tests needed minor updates due to the new bootstrap UI - some tests threw StaleElementReference exceptions when they tried to access elements after clicking a hyperlink which reloaded the page; fixed that too tested with: cd it-selenium mvn clean integration-test -Dwebdriver.gecko.driver=/path/to/geckodriver used: geckodriver v0.26.0 on 64bit linux, latest firefox, jdk 14 and everything worked fine. note: do a mvn install of the roller root project first. Doing this for ./app is not sufficient since the tests look for the project pom/war in local repo, not roller.war. note2: the test will display a few meters of jetty "class scanned from multiple locations" warnings since the classpath is apperently set to target/ and the local copy in the maven repo. Isn't convention over configuration great? I did not further attempt to fix this after trying out some different dependency scopes without any effect.
|
@snoopdave forgot to ping :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration tests should be working again.
commit msg:
clicking a hyperlink which reloaded the page; fixed that too
tested with:
cd it-selenium
mvn clean integration-test -Dwebdriver.gecko.driver=/path/to/geckodriver
used:
geckodriver v0.26.0 on 64bit linux, latest firefox, jdk 14 and everything worked fine.
note:
do a mvn install of the roller root project first. Doing this for ./app is not sufficient
since the tests look for the project pom/war in local repo, not roller.war.
note2:
the test will display a few meters of jetty "class scanned from multiple locations" warnings
since the classpath is apperently set to target/ and the local copy in the maven repo.
Isn't convention over configuration great? I did not further attempt to fix this after trying
out some different dependency scopes without any effect.