minor dependency updates + test-summary workflow action #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
force-pushed
the
dependency_updates_2
branch
3 times, most recently
from
5079c55
to
ce1ceb1
Compare
mbien
force-pushed
the
dependency_updates_2
branch
3 times, most recently
from
f22f88b
to
57e61ef
Compare
|
ok thats weird. I can't explain right now why this PR started failing. Can't reproduce this issue locally and I basically reverted everything already. |
mbien
force-pushed
the
dependency_updates_2
branch
from
a36cf44
to
e40f041
Compare
|
there you go. Some test annotations were missing. Whats interesting however is that the tests run in a different order on github than they do on my system locally. Once the MediaFile test started running first, it failed since it didn't boostrap roller. |
|
some notes on dependency bumps:
|
- use the geckodriver of the test runner - enable xserver for headful integration testing - strip repo credentials after checkout just to be sure
- asm - commons text - eclipse link - apache lucene - spring - jquery webjars - various maven plugins
mbien
force-pushed
the
dependency_updates_2
branch
from
e40f041
to
f60e75f
Compare
tested locally |
mbien
commented
Mar 23, 2023
| <rome.version>1.18.0</rome.version> | ||
| <rome.version>1.19.0</rome.version> <!-- locked in place since next version removes popono --> |
There was a problem hiding this comment.
another lib which is now locked since rome popono is gone
|
all green. @snoopdave approved via dev list -> merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It writes test reports directly to the workflow summary page (not to checks, which felt like a workaround anyway).
1920 in the test matrixtested locally.. lets see if everything builds with CI too