Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Add PHPStan rule level 10 #8010

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[PHP] Add PHPStan rule level 10 #8010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion php/php.code.analysis/src/org/netbeans/modules/php/analysis/options/AnalysisOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public final class AnalysisOptions {
private static final String PHPSTAN_CONFIGURATION = "phpstan.configuration"; // NOI18N
private static final String PHPSTAN_MEMORY_LIMIT = "phpstan.memory.limit"; // NOI18N
public static final int PHPSTAN_MIN_LEVEL = Integer.getInteger("nb.phpstan.min.level", 0); // NOI18N
public static final int PHPSTAN_MAX_LEVEL = Integer.getInteger("nb.phpstan.max.level", 9); // NOI18N
public static final int PHPSTAN_MAX_LEVEL = Integer.getInteger("nb.phpstan.max.level", 10); // NOI18N
// Psalm - PHP Static Analysis Tool
private static final String PSALM_PATH = "psalm.path"; // NOI18N
private static final String PSALM_LEVEL = "psalm.level"; // NOI18N
Expand Down
43 changes: 0 additions & 43 deletions ....code.analysis/src/org/netbeans/modules/php/analysis/ui/PHPStanLevelListCellRenderer.java
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions ...de.analysis/src/org/netbeans/modules/php/analysis/ui/analyzer/PHPStanCustomizerPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
import org.netbeans.modules.analysis.spi.Analyzer;
import org.netbeans.modules.php.analysis.commands.PHPStan;
import org.netbeans.modules.php.analysis.options.AnalysisOptions;
import org.netbeans.modules.php.analysis.ui.PHPStanLevelListCellRenderer;
import org.netbeans.modules.php.analysis.options.AnalysisOptionsValidator;
import org.netbeans.modules.php.analysis.options.ValidatorPHPStanParameter;
import org.netbeans.modules.php.analysis.ui.AnalysisDefaultDocumentListener;
Expand Down Expand Up @@ -121,7 +120,6 @@ private void initLevelComboBox() {
phpStanLevelComboBox.addItem(String.valueOf(i));
}
phpStanLevelComboBox.addItem(PHPStan.MAX_LEVEL);
phpStanLevelComboBox.setRenderer(new PHPStanLevelListCellRenderer(phpStanLevelComboBox.getRenderer()));
phpStanLevelComboBox.setSelectedItem(getValidLevel());
phpStanLevelComboBox.addItemListener(e -> setLevel());
}
Expand Down
2 changes: 0 additions & 2 deletions ...p.code.analysis/src/org/netbeans/modules/php/analysis/ui/options/PHPStanOptionsPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
import org.netbeans.modules.php.analysis.options.AnalysisOptions;
import org.netbeans.modules.php.analysis.options.AnalysisOptionsValidator;
import org.netbeans.modules.php.analysis.ui.AnalysisDefaultDocumentListener;
import org.netbeans.modules.php.analysis.ui.PHPStanLevelListCellRenderer;
import org.netbeans.modules.php.analysis.options.ValidatorPHPStanParameter;
import org.netbeans.modules.php.analysis.util.AnalysisUiUtils;
import org.netbeans.modules.php.api.validation.ValidationResult;
Expand Down Expand Up @@ -78,7 +77,6 @@ private void init() {
phpStanLevelComboBox.addItem(String.valueOf(i));
}
phpStanLevelComboBox.addItem(PHPStan.MAX_LEVEL);
phpStanLevelComboBox.setRenderer(new PHPStanLevelListCellRenderer(phpStanLevelComboBox.getRenderer()));
// add listener
DocumentListener defaultDocumentListener = new AnalysisDefaultDocumentListener(() -> fireChange());
phpStanTextField.getDocument().addDocumentListener(defaultDocumentListener);
Expand Down
Loading