Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Add PHPStan rule level 10 #8010

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

KacerCZ
Copy link
Contributor

@KacerCZ KacerCZ commented Dec 1, 2024

Added rule level 10.
Removed special rendering of max rule level because "max" is individual option.
Reference:

Before:

Screenshot from 2024-12-01 17-50-10

After:
Screenshot from 2024-12-01 17-53-16

Added new rule level.
Removed special rendering of max rule level because "max" is individual option.
Reference:
- https://phpstan.org/user-guide/rule-levels
@KacerCZ KacerCZ added enhancement PHP [ci] enable extra PHP tests (php/php.editor) labels Dec 1, 2024
@KacerCZ KacerCZ added this to the NB25 milestone Dec 1, 2024
@KacerCZ KacerCZ requested a review from junichi11 December 1, 2024 17:11
Copy link
Member

@junichi11 junichi11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@KacerCZ KacerCZ merged commit 2e32e97 into apache:master Dec 3, 2024
32 checks passed
@KacerCZ KacerCZ deleted the phpstan-new-rule-level branch December 3, 2024 18:28
@KacerCZ
Copy link
Contributor Author

KacerCZ commented Dec 3, 2024

@junichi11 Thank you for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants