Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental maven download feature. #7182

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Remove experimental maven download feature. #7182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/maven/nbproject/project.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test.config.stableBTD.excludes=\

jnlp.indirect.files=maven-nblib/netbeans-eventspy.jar,maven-nblib/netbeans-cos.jar

# requires nb.javac for compiling of tests
# TODO remove after JDK 17 bump (code uses CompilationUnitTree#getModule)
requires.nb.javac=true
Comment on lines -37 to 38
Copy link
Member Author

@mbien mbien Mar 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since gradle support is going to be 17+, maybe we should do this here too. I saw some sig validation issues in the log when I tried this so I didn't really bother. However that was before #7117, maybe I should give it another try.


test-unit-sys-prop.test.netbeans.dest.dir=${netbeans.dest.dir}
Loading
Loading