Remove experimental maven download feature. #7182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Code cleanup
Maven
mbien
commented
Mar 24, 2024
Comment on lines
-37
to
38
| # requires nb.javac for compiling of tests | ||
| # TODO remove after JDK 17 bump (code uses CompilationUnitTree#getModule) | ||
| requires.nb.javac=true |
There was a problem hiding this comment.
since gradle support is going to be 17+, maybe we should do this here too. I saw some sig validation issues in the log when I tried this so I didn't really bother. However that was before #7117, maybe I should give it another try.
matthiasblaesing
approved these changes
Mar 24, 2024
java/maven/src/org/netbeans/modules/maven/options/MavenSettings.java
Outdated
Show resolved
Hide resolved
Got superseded by mvnw.
mbien
removed
the
ci:dev-build
mbien
force-pushed
the
remove-maven-download-feature
branch
from
0c90154 to
cecb233
Compare
I am following the maven dev list a bit and I don't think we have to worry about that. Maven 4 won't have a different approach to compatibility than Maven 3 has. Maven 3 will also stick around for a while in maintenance mode. |
matthiasblaesing
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
got replaced by mvnw #3198 / #7076 (comment)