Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for removing Micronaut symbols from index. #6996

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Jan 25, 2024

Micronaut symbols removed from sources should be deleted from index too.

@dbalek dbalek added the Micronaut [ci] enable enterprise job label Jan 25, 2024
@dbalek dbalek added this to the NB22 milestone Jan 25, 2024
@dbalek dbalek self-assigned this Jan 25, 2024
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Tests might be nice :-).

@MartinBalin
Copy link
Contributor

This is bug which prevents Micronaut Tools windows in VSCode from updating and still shows removed Controller. Has to go to delivery and NB21.

@dbalek dbalek changed the base branch from master to delivery January 26, 2024 09:10
@dbalek dbalek changed the base branch from delivery to master January 26, 2024 09:11
@dbalek
Copy link
Contributor Author

dbalek commented Jan 26, 2024

Unfortunately, simple rebasing would bring a lot of unwanted commits to delivery. Merging to master.

@dbalek dbalek merged commit f84f064 into apache:master Jan 26, 2024
34 checks passed
@dbalek dbalek deleted the dbalek/micronaut-symbol-remove branch January 26, 2024 09:24
@neilcsmith-net
Copy link
Member

@dbalek so you're saying this change cannot go into NB21?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Micronaut [ci] enable enterprise job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants