LSP: Do not compute text edits in source actions on resolve call.
#6990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbalek
added
LSP
MartinBalin
approved these changes
Jan 24, 2024
sdedic
approved these changes
Jan 25, 2024
...va.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/EqualsHashCodeGenerator.java
Show resolved
Hide resolved
|
This has to go to NB21 as when using mouse, like those of us who don't remember 3keys shortcut on mac then this always triggers the action when hoovering over menu item. Ugly behaviour now in VSCode. |
|
Unfortunately, simple rebasing would bring a lot of unwanted commits to delivery. Merging to master. |
|
@dbalek so you're saying this change cannot go into NB21? |
|
Exactly @neilcsmith-net , too difficult to make it to NB21. |
|
Thanks @MartinBalin There are two PRs (this and #6996 ) that you've said must go in NB21 and then have been merged to master without confirmation from you in review. Just checking we're not expecting anything related to either to hit delivery? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified to follow change in VSCode behavior when
codeAction/resolveLSP call is invoked also on mouse hover and not only on source action selection (see microsoft/vscode#175008). The source actions that require user interaction to compute their workspace edits should no more do it oncodeAction/resolve.