Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP: Fixing cancelability bugs by reverting from a for each loop to a normal loop #6853

Merged
merged 1 commit into from
Dec 15, 2023
Merged

PHP: Fixing cancelability bugs by reverting from a for each loop to a normal loop #6853

merged 1 commit into from
Dec 15, 2023

Conversation

troizet
Copy link
Collaborator

@troizet troizet commented Dec 15, 2023

See discussion in comments #5648 (comment).

@troizet troizet added the PHP [ci] enable extra PHP tests (php/php.editor) label Dec 15, 2023
junichi11
junichi11 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@junichi11 junichi11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@junichi11 junichi11 added this to the NB21 milestone Dec 15, 2023
@junichi11 junichi11 merged commit 589218b into apache:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junichi11 junichi11 junichi11 approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB21
Development

Successfully merging this pull request may close these issues.
2 participants
@troizet @junichi11