PHP: Adding a new error hint, as suggested in #5078. #5648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbownik
reviewed
Mar 10, 2023
...r/src/org/netbeans/modules/php/editor/verification/ReturnStatementWithoutValueHintError.java
Outdated
Show resolved
Hide resolved
troizet
force-pushed
the
return_statement_filled_value_hint
branch
2 times, most recently
from
e3b557b to
035ad15
Compare
|
@troizet Please implement it in |
|
That's what I did at first. Then I decided it would be easier to do it separately. OK, I'll try again. Thank you! |
troizet
force-pushed
the
return_statement_filled_value_hint
branch
from
035ad15 to
4b1c713
Compare
junichi11
reviewed
Mar 14, 2023
php/php.editor/src/org/netbeans/modules/php/editor/verification/ReturnTypeHintError.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Mar 14, 2023
php/php.editor/src/org/netbeans/modules/php/editor/verification/ReturnTypeHintError.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Mar 14, 2023
...data/testfiles/verification/ReturnTypeHintError/testReturnStatementWithoutValueHintError.php
Show resolved
Hide resolved
|
Please fix the commit message and the title of this PR. Thanks! |
tmysik
reviewed
Mar 14, 2023
php/php.editor/src/org/netbeans/modules/php/editor/verification/ReturnTypeHintError.java
Outdated
Show resolved
Hide resolved
tmysik
reviewed
Mar 14, 2023
php/php.editor/src/org/netbeans/modules/php/editor/verification/ReturnTypeHintError.java
Show resolved
Hide resolved
tmysik
reviewed
Mar 14, 2023
php/php.editor/src/org/netbeans/modules/php/editor/verification/ReturnTypeHintError.java
Outdated
Show resolved
Hide resolved
tmysik
reviewed
Mar 14, 2023
…ue if the return type is specified for the function, as suggested in apache#5078 Fixing the cancelability bug in ReturnTypeHintError by reverting from a for each loop to a normal loop
troizet
force-pushed
the
return_statement_filled_value_hint
branch
from
4b1c713 to
f55ac21
Compare
troizet
changed the title
|
@junichi11 Not sure whether we need all the approvals; if not, feel free to merge anytime. Thank you. |
|
Thanks to all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new hint that checks if the return statement has a value if the return type is specified for the function, as suggested in #5078.