Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JUnit output processing for failsafe:integration-test #6654

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

neilcsmith-net
Copy link
Member

This is a partial quick fix for showing the test output window when the Maven goals include failsafe:integration-test, as in the default mapping introduced in #4096

This is possibly a fix for #6448

While testing this I noticed that we're not calling post-integration-test in the default mapping, which we should probably do. Adding that however shows another empty unit test output. The output test result listeners probably needs some adaptation here, and possibly shouldn't open when all tests are skipped or there are none? That is all left for NB21!

@neilcsmith-net neilcsmith-net added Maven [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Nov 2, 2023
@neilcsmith-net neilcsmith-net added this to the NB20 milestone Nov 2, 2023
Copy link
Contributor

@ebarboni ebarboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilcsmith-net neilcsmith-net merged commit 7c99436 into apache:delivery Nov 2, 2023
@neilcsmith-net neilcsmith-net deleted the gh6448 branch January 16, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants