Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntegrationTest results of aQuarkus-project are not shown in Test Results window #6448

Closed
ChMThiel opened this issue Sep 14, 2023 · 7 comments
Labels
kind:bug Bug report or fix Maven [ci] enable "build tools" tests Quarkus
Milestone

Comments

@ChMThiel
Copy link

Apache NetBeans version

Apache NetBeans 19

What happened

After running an IT of a Quarkus-project i expect to see the test-results in the Test Results tab.
But nothing is shown...

How to reproduce

  1. Create a new Quarkus-project (see https://quarkus.io/get-started/)
  2. Open the project in netbeans
  3. Navigate to the GreetingResourceIT
    3.1. right-klick -> 'Test file'
    3.2 Re-run with different parameters, add skipITs=false (IT will be skipped by default, see https://quarkus.io/guides/getting-started-testing#quarkus-integration-test)

Did this work correctly in an earlier version?

Apache NetBeans 13 or earlier

Operating System

Kubuntu

JDK

jdk-17.0.2

Apache NetBeans packaging

Apache NetBeans Snap Package

Anything else

No response

Are you willing to submit a pull request?

No

@ChMThiel ChMThiel added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Sep 14, 2023
@neilcsmith-net neilcsmith-net added Maven [ci] enable "build tools" tests and removed needs:triage Requires attention from one of the committers labels Sep 14, 2023
@neilcsmith-net
Copy link
Member

Can replicate with a basic project. Only unit test results are shown in the test result window.

This didn't work correctly before, btw - it would run the integration test as a unit test.

Putting the milestone on for tracking purposes for now.

@neilcsmith-net neilcsmith-net added this to the NB20 milestone Sep 14, 2023
@sroeper
Copy link
Contributor

sroeper commented Oct 5, 2023

@neilcsmith-net Can also replicate this behaviour. Switching to an older maven version (i.e. 3.8.6) shows the test results in the output window (no test result window is shown).
With maven >= 3.9.3 there is no output from the maven-failsafe-plugin shown, only build success.
Both tests with the maven-failsafe-plugin version 3.1.2 (latest).

"This didn't work correctly before, btw - it would run the integration test as a unit test."

I don't think you are right with this. I can clearly see the maven command at the beginning of the output window and this says mvn pre-integration-test failsafe:integration-test
What would you expect as maven command for an integration test?

@sroeper
Copy link
Contributor

sroeper commented Oct 5, 2023

@neilcsmith-net, @ChMThiel
If you go to Project Properties / Actions / Integration test file and remove all properties except it.test=${packageClassName} then you will get at least an output to the output window (but the Test result window will not open)

@neilcsmith-net
Copy link
Member

I don't think you are right with this. I can clearly see the maven command at the beginning of the output window and this says mvn pre-integration-test failsafe:integration-test What would you expect as maven command for an integration test?

@sroeper that! This changed in NB14 with #4096 The Test Results UI was reported as working above in NB13 or earlier - eg. when the integration test was being run as a unit test.

@neilcsmith-net
Copy link
Member

Added a minimal change that at least triggers the test output UI if failsafe:integration-test is in the goals. Curious if you can check a dev build from https://github.com/apache/netbeans/actions/runs/6732400660 when it completes (zip will be under graph), and see if that helps at all with your particular project?

@ChMThiel
Copy link
Author

ChMThiel commented Nov 3, 2023

I'll give it a try - works like a charm

@neilcsmith-net
Copy link
Member

Thanks @ChMThiel . This change is in 20-rc3 now linked from #6581

Will close, but comment if there are any problems. There's certainly some more we could improve just here, as mentioned in the pull request description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Bug report or fix Maven [ci] enable "build tools" tests Quarkus
Projects
None yet
Development

No branches or pull requests

4 participants