Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed display of hints descriptions for php in the hints settings #5649

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

troizet
Copy link
Collaborator

@troizet troizet commented Mar 10, 2023

Accidental Assignments

before:
bug_1

after:
fixed_1

Immutable Variables

before:
bug_2

after:
fixed_2

Uninitialized Variables

before:
bug_3

after:
fixed_3

Unused Variables

before:
bug_4

after:
fixed_4

@mbien mbien added PHP [ci] enable extra PHP tests (php/php.editor) UI User Interface labels Mar 10, 2023
@mbien mbien added this to the NB18 milestone Mar 10, 2023
@mbien
Copy link
Member

mbien commented Mar 10, 2023

excellent. I thought I caught all panels which had this issue (e.g #3472, #4906) - apparently not. Thanks a lot for fixing this!

@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Mar 10, 2023
@apache apache locked and limited conversation to collaborators Mar 10, 2023
@apache apache unlocked this conversation Mar 10, 2023
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all green. tested locally. merging.

thanks again!

@mbien mbien merged commit 7da74a5 into apache:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) PHP [ci] enable extra PHP tests (php/php.editor) UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants