Maven HintsPanel UI layout fixes and minor cleanup. #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- analog to apache#3472, this fixes UI component resize behavior - description panel is now filling the space vertically like in the java version of this panel. Text is now wrapping properly. - the option panels had to be adjusted to prefer their minimum default size - minor language cleanup: diamonds, lambdas
|
Just to be sure I've not overlooked anything: no functional change, just layout & cleanup anonymous -> lambda ? |
right. this is primarily about UI layouts. The lamda cleanup is just a cleanup, no logic changed there. |
- analog to apache#3472, this fixes UI component resize behavior - updated all other HintsPanels to have the same initial divider pos - minor cleanup like lambdas and diamonds
|
added another commit for the CSL HintsPanel. All three panels have now been updated. They have the same initial divider locations and look and behave just as if they would be the same component. |
|
Weird thing is the issue isn't reproducible with a clean userdir until the options window is resized. Makes sense, and as we're having another rc, let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targets delivery. But this is fairly low priority. Noticed those UI issues while writing the maven release version hint.