Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven EventSpy not compatible < JDK 1.8 #5548

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Maven EventSpy not compatible < JDK 1.8 #5548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public class MavenCommandLineExecutor extends AbstractMavenExecutor {
private String processUUID;
private Process preProcess;
private String preProcessUUID;
private static final SpecificationVersion VER17 = new SpecificationVersion("1.7"); //NOI18N
private static final SpecificationVersion VER18 = new SpecificationVersion("1.8"); //NOI18N
private static final Logger LOGGER = Logger.getLogger(MavenCommandLineExecutor.class.getName());

private static final RequestProcessor RP = new RequestProcessor(MavenCommandLineExecutor.class.getName(),1);
Expand Down Expand Up @@ -397,11 +397,11 @@ public void actionPerformed(ActionEvent e) {
}

private boolean isEventSpyCompatible(final BeanRunConfig clonedConfig) {
// EventSpy cannot work on jdk < 7
// EventSpy cannot work on jdk < 8
if (clonedConfig.getProject() != null) {
ActiveJ2SEPlatformProvider javaprov = clonedConfig.getProject().getLookup().lookup(ActiveJ2SEPlatformProvider.class);
JavaPlatform platform = javaprov.getJavaPlatform();
return (platform.getSpecification().getVersion().compareTo(VER17) >= 0);
return (platform.getSpecification().getVersion().compareTo(VER18) >= 0);
} else {
return true;
}
Expand Down