Maven EventSpy not compatible < JDK 1.8 #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @graben, thanks for the update. But before we can merge this you would have to update the commit to a valid email address, we would like to avoid having noreply mails in the git history. to fix the commit you can run: after that simply force push again into this PR. here is also a guide how to change this globally in your git settings: |
mbien
added
the
do not merge
|
@mbien : Email address should be set, now. |
mbien
removed
the
do not merge
|
@graben I just noticed, do you want to update the comment at L400 so that it fits to the new code? github doesn't let me mark it since it is not part of the changeset |
|
@mbien : Sure, missed that comment the first time |
mbien
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.