add-open flag for archetype

[ebarboni]

Attempt to pass the add open flags to archetype linked to use for apache/netbeans-mavenutils-archetype-nbm-archetype#9

I should alter nbbuild/build.xml to populate branding so it can be used for replacement in the module

[mbien]

LGTM + tested it and it works great. good job.

[ebarboni]

it add flag like this '''-J--add-opens=java.base/java.net=ALL-UNNAMED -J--add-opens=java.base/java.lang.ref=ALL-UNNAMED''' maybe we should have the without -J version too.

[ebarboni]

@mbien add the two properties for maven user will be easy to get both I guess even if user doesn't want them at the end. Easier to delete than to create.

[ebarboni]

#3862 needs also the jvm version for flags

[ebarboni]

wait PR to be merged and git checkout build.xml and default.xml. Idea of @matthiasblaesing was my first intention but did'nt proper understand where to put things.

[mbien]

do we really need two properties? Is there nothing which could add the -J for the mavenproject.conf?

I assume the updated archetype will insert the properties to surefire configuration/argline etc?

[ebarboni]

I would prefers having both and let maven user choose. On nbm-application you may need both and avoid the maven-antrun-plugin.
Not 100% sure

[mbien]

just a thought: would it be possible to make the launcher smarter so that it could use something like:
-J'-flag1 -flag2 -flag3' or -JVM_FLAGS='-flag1 -flag2 -flag3'?

[ebarboni]

It's a more heavy change, for windows it would be there https://github.com/apache/netbeans-native-launchers unsure on how it works on mac

[neilcsmith-net]

@ebarboni status of this one?

[ebarboni]

later :D it needs also archetype side rewrite, I need to resync with @mbien

[mbien]

maybe we should just add a comment to the maven template (which links to our JMS file) and call it a day, since this ended up more difficult than anticipated :)

(i really don't like the fact that this would need two properties, one with -J and one without)