introduce properties for flags list #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
approved these changes
Mar 24, 2022
|
@mbien not only but this is on two repository :D |
|
@mbien I just added the two differents add-open IDE style and jdk style. |
mbien
reviewed
Apr 1, 2022
Comment on lines
14
to
17
| <!-- jms flags with IDE prefix --> | ||
| <addopenflags>${addopensflagsList}</addopenflags> | ||
| <!-- jms flags standard --> | ||
| <addopenfflags>${addopensfflagsList}</addopenflags> |
There was a problem hiding this comment.
is there no way to avoid this somehow? Why does the maven archetype need to know about the "-J" list too?
There was a problem hiding this comment.
I will remove this, the nbm-application that may need the -J is for the other archetype.
|
ok hope this is good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the #2 followup to let NetBeans set the addopensflagsList properties itself.
Should let end user configuring in only one place in case of evolution