This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
pengzhao-intel
added
the
Quantization
Issues/Feature Requests related to Quantization
label
Dec 23, 2019
ciyongch
reviewed
Dec 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add some tests to cover this new ops.
@ciyongch thx, please review again:) |
ciyongch
reviewed
Dec 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need another simple test case to cover fusion pattern based on subgraph.
xinyu-intel
force-pushed
the
ncf_remeasure
branch
from
December 25, 2019 03:20
a757490
to
afae436
Compare
xinyu-intel
changed the title
[WIP] Quantized Elemwise Mul Operator
Quantized Elemwise Mul Operator
Dec 25, 2019
pengzhao-intel
approved these changes
Dec 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ciyongch to review.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Quantized Elemwise Mul Operator for NCF further optimization.
@pengzhao-intel @TaoLv @ciyongch
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments