Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up sleep in TestBackwardsCompatibility#testCreateMoreTermsIndex #12914

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Clean up sleep in TestBackwardsCompatibility#testCreateMoreTermsIndex #12914

merged 1 commit into from
Jan 8, 2024

Conversation

gf2121
Copy link
Contributor

@gf2121 gf2121 commented Dec 11, 2023

No description provided.

@gf2121 gf2121 mentioned this pull request Dec 11, 2023
Closed
mikemccand
mikemccand approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@mikemccand mikemccand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it -- why aren't we seeing that TestBackwardsCompatibility times out every time we run it?

@uschindler
Copy link
Contributor

I don't get it -- why aren't we seeing that TestBackwardsCompatibility times out every time we run it?

The magic is here:

lucene/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java

Line 197 in 2acf76e

assumeTrue(
🫣

benwtrent
benwtrent approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

WOW this code is so much faster now!!! GREAT OPTIMIZATION!!! 😂

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions bot added the Stale label Jan 8, 2024
@uschindler uschindler merged commit 67be018 into apache:main Jan 8, 2024
4 checks passed
@uschindler uschindler added this to the 9.10.0 milestone Jan 8, 2024
@uschindler uschindler self-assigned this Jan 8, 2024
asfgit pushed a commit that referenced this pull request Jan 8, 2024
@gf2121 @uschindler
clean up sleep (#12914)
834ad7c
@uschindler
Copy link
Contributor

Thanks @gf2121, I merged this stale PR.

stefanvodita pushed a commit to stefanvodita/lucene that referenced this pull request Jan 9, 2024
@gf2121 @stefanvodita
clean up sleep (apache#12914)
b780dd7
slow-J pushed a commit to slow-J/lucene that referenced this pull request Jan 16, 2024
@gf2121 @slow-J
clean up sleep (apache#12914)
f0558a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemccand mikemccand mikemccand approved these changes

@uschindler uschindler uschindler approved these changes

@benwtrent benwtrent benwtrent approved these changes

Assignees

@uschindler uschindler

Labels
type:enhancement type:test
Projects
None yet
Milestone
9.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gf2121 @uschindler @mikemccand @benwtrent