Add BWC test to reveal #12895 #12912
Conversation
|
|
||
| // Gives you time to copy the index out!: (there is also | ||
| // a test option to not remove temp dir...): | ||
| Thread.sleep(100000); |
There was a problem hiding this comment.
this must go away, please add nocommit.
There was a problem hiding this comment.
I thought -Ptests.bwcdir= made this sleep hack unnecessary? Seems like we shouldn't have any of these data generative tests using Thread.sleep.
There was a problem hiding this comment.
Thanks for review @uschindler @benwtrent !
I closed this since I saw @mikemccand did similar things and his dictionary is much smaller than mine :)
this must go away, please add nocommit.
I'm very new to this part. I copied this pattern from another existing test . I can open another PR to clean this up if we are sure it makes no sense.
There was a problem hiding this comment.
wwwwuuuuuuaaaaaaah. This must go away.
|
Oh thanks for working on this @gf2121 -- sorry that we both did it at the same time! |
|
... but at least it lead to discovering a horrifying Can we ban |
|
Solr used that, as solr is no longer part of our tree we could add sleep to fobiddenaps (maybe globally for both tests and main code). Maybe Lucene does not sleep in tests, so it could be an easy PR. Let's investigate. 🫣 |
Awesome, I opened #12946 for this. |
This patch get a 40000-terms subset (~200KB) of
wikibigallterms dict, which can reproduce #12895. I have verified #12900 can fix the expection.