more modern coding style #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use collection expressions - removed prefix m_ from private fields
fluffynuts
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Just the one comment now - I support removing the C-style m prefix, but I'd like to retain the C#-style _ prefix for private fields, if for no other reason than it makes it much easier to determine, at a glance, the difference between a local var and an instance field. Thoughts?
src/log4net.Tests/Appender/AdoNet/Log4NetParameterCollection.cs
Outdated
Show resolved
Hide resolved
|
Alright. You convinced me. |
I don't mind - wherever is most convenient (: |
FreeAndNil
force-pushed
the
Feature/FilescopedNamespaces
branch
2 times, most recently
from
f0083f7 to
8284d7b
Compare
|
@fluffynuts I've adjusted the names with the help of the refactoring in rider and added the missing entries in .editorconfig. |
fluffynuts
approved these changes
Oct 18, 2024
FreeAndNil
added a commit
that referenced
this pull request
Oct 24, 2024
This was referenced Dec 18, 2024
FreeAndNil
pushed a commit
that referenced
this pull request
Dec 19, 2024
FreeAndNil
pushed a commit
that referenced
this pull request
Dec 19, 2024
FreeAndNil
pushed a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_for private fields