Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change to FileAppender in a third-digit release #216

Closed
sketchturner opened this issue Dec 18, 2024 · 7 comments · Fixed by #217
Closed

Breaking change to FileAppender in a third-digit release #216

sketchturner opened this issue Dec 18, 2024 · 7 comments · Fixed by #217
Assignees
Milestone

Comments

@sketchturner
Copy link
Contributor

A change to FileAppender that breaks backward compatibility was introduced with #196.
SetQWForFiles is a publicly visible method that was renamed to SetQwForFiles. Need to rename it back in order to keep types that extend FileAppender compatible with the latest version of log4net

@garydgregory
Copy link
Member

I don't think we should keep BC outside of log4-api, but that's just me.

@FreeAndNil
Copy link
Contributor

FreeAndNil commented Dec 19, 2024

I don't think we should keep BC outside of log4-api, but that's just me.

@garydgregory log4net is monolithic, we have no separate api (as log4j).

@FreeAndNil FreeAndNil self-assigned this Dec 19, 2024
@FreeAndNil FreeAndNil added this to the 3.0.4 milestone Dec 19, 2024
@FreeAndNil
Copy link
Contributor

@sketchturner thanks.
Do you need a preview version of log4net?

@garydgregory
Copy link
Member

I don't think we should keep BC outside of log4-api, but that's just me.

@garydgregory log4net is monolithic, we have no separate api (as log4j).

Well, please accept my apologies and ignore my comment because I thought this was a log4j thread! 🤦

@sketchturner
Copy link
Contributor Author

@FreeAndNil thanks. I can wait for a stable release of version 3.0.4.
By the way, is it by any chance possible to amend the message of the commit that was the result of #217 completion in order to remove the "Co-authored-by" part? Thanks

@FreeAndNil
Copy link
Contributor

FreeAndNil commented Dec 19, 2024

By the way, is it by any chance possible to amend the message of the commit that was the result of #217 completion in order to remove the "Co-authored-by" part? Thanks

@sketchturner see 1a6ff0f

@sketchturner
Copy link
Contributor Author

@FreeAndNil Great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants