[Bug][Flink] EmbeddedExecutorFactory not thread-safe during bootstrap #5080
Labels
Comments
link3280
changed the title
link3280
changed the title
link3280
added a commit
to link3280/kyuubi
that referenced
this issue
Jul 21, 2023
…fe during bootstrap
link3280
added a commit
to link3280/kyuubi
that referenced
this issue
Jul 23, 2023
…fe during bootstrap ### _Why are the changes needed?_ As titled. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request Closes apache#5082 from link3280/KYUUBI-5080. Closes apache#5080 e8026b8 [Paul Lin] [KYUUBI apache#4806][FLINK] Improve logs fd78f32 [Paul Lin] [KYUUBI apache#4806][FLINK] Fix gateway NPE a0a7c44 [Cheng Pan] Update externals/kyuubi-flink-sql-engine/src/main/java/org/apache/flink/client/deployment/application/executors/EmbeddedExecutorFactory.java 50830d4 [Paul Lin] [KYUUBI apache#5080][FLINK] Fix EmbeddedExecutorFactory not thread-safe during bootstrap Lead-authored-by: Paul Lin <paullin3280@gmail.com> Co-authored-by: Cheng Pan <pan3793@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this issue
Jul 24, 2023
…fe during bootstrap ### _Why are the changes needed?_ As titled. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request Closes apache#5082 from link3280/KYUUBI-5080. Closes apache#5080 e8026b8 [Paul Lin] [KYUUBI apache#4806][FLINK] Improve logs fd78f32 [Paul Lin] [KYUUBI apache#4806][FLINK] Fix gateway NPE a0a7c44 [Cheng Pan] Update externals/kyuubi-flink-sql-engine/src/main/java/org/apache/flink/client/deployment/application/executors/EmbeddedExecutorFactory.java 50830d4 [Paul Lin] [KYUUBI apache#5080][FLINK] Fix EmbeddedExecutorFactory not thread-safe during bootstrap Lead-authored-by: Paul Lin <paullin3280@gmail.com> Co-authored-by: Cheng Pan <pan3793@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
Describe the bug
Currently, EmbeddedExecutorFactory that Flink application mode relies on is not thread-safe. If a new SQL is submitted at the same time as the bootstrap SQL, NPE occurs.
See the failed CI https://github.com/apache/kyuubi/actions/runs/5610938813/job/15201466145 for details.
Affects Version(s)
1.8
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: