[KYUUBI apache#4806][FLINK] Improve logs

link3280 · Jul 22, 2023 · e8026b8 · e8026b8
1 parent fd78f32
commit e8026b8
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/...ava/org/apache/flink/client/deployment/application/executors/EmbeddedExecutorFactory.java b/...ava/org/apache/flink/client/deployment/application/executors/EmbeddedExecutorFactory.java
@@ -88,6 +88,7 @@ public EmbeddedExecutorFactory(
     synchronized (bootstrapLock) {
       // submittedJobIds would be always 1, because we create a new list to avoid concurrent access
       // issues
+      LOGGER.debug("Bootstrapping EmbeddedExecutorFactory.");
       EmbeddedExecutorFactory.submittedJobIds =
           new ConcurrentLinkedQueue<>(checkNotNull(submittedJobIds));
       EmbeddedExecutorFactory.bootstrapJobIds = submittedJobIds;
@@ -105,7 +106,7 @@ public String getName() {
   @Override
   public boolean isCompatibleWith(final Configuration configuration) {
     // override Flink's implementation to allow usage in Kyuubi
-    LOGGER.debug("matching execution target: {}", configuration.get(DeploymentOptions.TARGET));
+    LOGGER.debug("Matching execution target: {}", configuration.get(DeploymentOptions.TARGET));
     return configuration.get(DeploymentOptions.TARGET).equalsIgnoreCase("yarn-application")
         && configuration.toMap().getOrDefault("yarn.tags", "").toLowerCase().contains("kyuubi");
   }
@@ -119,6 +120,7 @@ public PipelineExecutor getExecutor(final Configuration configuration) {
       int retry = 0;
       while (bootstrapJobIds == null && retry < BOOTSTRAP_WAIT_RETRIES) {
         try {
+          LOGGER.debug("Waiting for bootstrap to complete. Wait retries: {}.", retry);
           bootstrapLock.wait(BOOTSTRAP_WAIT_INTERVAL);
           retry++;
         } catch (InterruptedException e) {
@@ -129,14 +131,14 @@ public PipelineExecutor getExecutor(final Configuration configuration) {
         throw new RuntimeException(
             "Bootstrap of Flink SQL engine timed out after "
                 + BOOTSTRAP_WAIT_INTERVAL * BOOTSTRAP_WAIT_RETRIES
-                + ". Please check the engine log for more details.");
+                + " ms. Please check the engine log for more details.");
       }
     }
     if (bootstrapJobIds.size() > 0) {
-      LOGGER.info("Submitting new Kyuubi job. Job already submitted: {}.", submittedJobIds.size());
+      LOGGER.info("Submitting new Kyuubi job. Job submitted: {}.", submittedJobIds.size());
       executorJobIDs = submittedJobIds;
     } else {
-      LOGGER.info("Bootstrapping Flink SQL engine.");
+      LOGGER.info("Bootstrapping Flink SQL engine with the initial SQL.");
       executorJobIDs = bootstrapJobIds;
     }
     return new EmbeddedExecutor(