Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-15740: KRaft support in DeleteOffsetsConsumerGroupCommandIntegrationTest #14669

Merged
merged 7 commits into from
Jan 15, 2024
Merged

KAFKA-15740: KRaft support in DeleteOffsetsConsumerGroupCommandIntegrationTest #14669

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c95049b
KRaft support in DeleteOffsetsConsumerGroupCommandIntegrationTest
linzihao1999 Oct 30, 2023
a34ba9c
minor
linzihao1999 Nov 3, 2023
ebc0d34
Merge branch 'apache:trunk' into KAFKA-15740
linzihao1999 Dec 20, 2023
3ac0634
Merge branch 'apache:trunk' into KAFKA-15740
linzihao1999 Dec 21, 2023
a826245
Merge branch 'apache:trunk' into KAFKA-15740
linzihao1999 Dec 23, 2023
692b72f
Merge branch 'apache:trunk' into KAFKA-15740
linzihao1999 Dec 25, 2023
9610edb
Merge branch 'apache:trunk' into KAFKA-15740
linzihao1999 Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 31 additions & 19 deletions core/src/test/scala/unit/kafka/admin/DeleteOffsetsConsumerGroupCommandIntegrationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import java.util.Properties

import kafka.server.Defaults
import kafka.utils.TestUtils
import kafka.utils.TestInfoUtils
import org.apache.kafka.clients.consumer.Consumer
import org.apache.kafka.clients.consumer.ConsumerConfig
import org.apache.kafka.clients.consumer.KafkaConsumer
Expand All @@ -32,8 +33,10 @@ import org.apache.kafka.common.protocol.Errors
import org.apache.kafka.common.serialization.ByteArrayDeserializer
import org.apache.kafka.common.serialization.ByteArraySerializer
import org.apache.kafka.common.utils.Utils
import org.junit.jupiter.api.Test

import org.junit.jupiter.api.Assertions._
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.ValueSource

class DeleteOffsetsConsumerGroupCommandIntegrationTest extends ConsumerGroupCommandTest {

Expand All @@ -46,8 +49,9 @@ class DeleteOffsetsConsumerGroupCommandIntegrationTest extends ConsumerGroupComm
)
}

@Test
def testDeleteOffsetsNonExistingGroup(): Unit = {
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testDeleteOffsetsNonExistingGroup(quorum: String): Unit = {
val group = "missing.group"
val topic = "foo:1"
val service = getConsumerGroupService(getArgs(group, topic))
Expand All @@ -56,43 +60,51 @@ class DeleteOffsetsConsumerGroupCommandIntegrationTest extends ConsumerGroupComm
assertEquals(Errors.GROUP_ID_NOT_FOUND, error)
}

@Test
def testDeleteOffsetsOfStableConsumerGroupWithTopicPartition(): Unit = {
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testDeleteOffsetsOfStableConsumerGroupWithTopicPartition(quorum: String): Unit = {
testWithStableConsumerGroup(topic, 0, 0, Errors.GROUP_SUBSCRIBED_TO_TOPIC)
}

@Test
def testDeleteOffsetsOfStableConsumerGroupWithTopicOnly(): Unit = {
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testDeleteOffsetsOfStableConsumerGroupWithTopicOnly(quorum: String): Unit = {
testWithStableConsumerGroup(topic, -1, 0, Errors.GROUP_SUBSCRIBED_TO_TOPIC)
}

@Test
def testDeleteOffsetsOfStableConsumerGroupWithUnknownTopicPartition(): Unit = {
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testDeleteOffsetsOfStableConsumerGroupWithUnknownTopicPartition(quorum: String): Unit = {
testWithStableConsumerGroup("foobar", 0, 0, Errors.UNKNOWN_TOPIC_OR_PARTITION)
}

@Test
def testDeleteOffsetsOfStableConsumerGroupWithUnknownTopicOnly(): Unit = {
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testDeleteOffsetsOfStableConsumerGroupWithUnknownTopicOnly(quorum: String): Unit = {
testWithStableConsumerGroup("foobar", -1, -1, Errors.UNKNOWN_TOPIC_OR_PARTITION)
}

@Test
def testDeleteOffsetsOfEmptyConsumerGroupWithTopicPartition(): Unit = {
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testDeleteOffsetsOfEmptyConsumerGroupWithTopicPartition(quorum: String): Unit = {
testWithEmptyConsumerGroup(topic, 0, 0, Errors.NONE)
}

@Test
def testDeleteOffsetsOfEmptyConsumerGroupWithTopicOnly(): Unit = {
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testDeleteOffsetsOfEmptyConsumerGroupWithTopicOnly(quorum: String): Unit = {
testWithEmptyConsumerGroup(topic, -1, 0, Errors.NONE)
}

@Test
def testDeleteOffsetsOfEmptyConsumerGroupWithUnknownTopicPartition(): Unit = {
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testDeleteOffsetsOfEmptyConsumerGroupWithUnknownTopicPartition(quorum: String): Unit = {
testWithEmptyConsumerGroup("foobar", 0, 0, Errors.UNKNOWN_TOPIC_OR_PARTITION)
}

@Test
def testDeleteOffsetsOfEmptyConsumerGroupWithUnknownTopicOnly(): Unit = {
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("zk", "kraft"))
def testDeleteOffsetsOfEmptyConsumerGroupWithUnknownTopicOnly(quorum: String): Unit = {
testWithEmptyConsumerGroup("foobar", -1, -1, Errors.UNKNOWN_TOPIC_OR_PARTITION)
}

Expand Down