Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15740: KRaft support in DeleteOffsetsConsumerGroupCommandIntegrationTest #14669

Merged
merged 7 commits into from
Jan 15, 2024

Conversation

linzihao1999
Copy link
Contributor

The tests in DeleteOffsetsConsumerGroupCommandIntegrationTest in core/src/test/scala/unit/kafka/admin/DeleteOffsetsConsumerGroupCommandIntegrationTest.scala update to support KRaft.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@linzihao1999
Copy link
Contributor Author

Hi @cmccabe @jsancio

The CI-builds finished and I found no failure test report about DeleteOffsetsConsumerGroupCommandIntegrationTest.
Is there more I need to do before code review. PTAL

https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14669/2//testReport/

@linzihao1999
Copy link
Contributor Author

Hi @mimaison PTAL

Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mimaison mimaison merged commit 8d89e63 into apache:trunk Jan 15, 2024
1 check failed
@linzihao1999 linzihao1999 deleted the KAFKA-15740 branch January 15, 2024 12:13
showuon pushed a commit to showuon/kafka that referenced this pull request Jan 22, 2024
…ationTest (apache#14669)


Reviewers: Mickael Maison <mickael.maison@gmail.com>, Qichao Chu <qichao@uber.com>
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
…ationTest (apache#14669)


Reviewers: Mickael Maison <mickael.maison@gmail.com>, Qichao Chu <qichao@uber.com>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
…ationTest (apache#14669)


Reviewers: Mickael Maison <mickael.maison@gmail.com>, Qichao Chu <qichao@uber.com>
Phuc-Hong-Tran pushed a commit to Phuc-Hong-Tran/kafka that referenced this pull request Jun 6, 2024
…ationTest (apache#14669)


Reviewers: Mickael Maison <mickael.maison@gmail.com>, Qichao Chu <qichao@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants